[Due for payment 2025-12-19][$250] Report - WS Chat auto-scrolls to latest message after "mark as paid" an expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.48-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1894/folder/13176705/41236828/1005354389
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Pixel 7 Pro /Android 16
App Component: Chat Report View

Action Performed:

Preconditions: The member has submitted some expense reports to the Workspace chat, and the admin has approved them before

1. Log in to Newdot as the admin
2. Navigate to the member Workspace chat
3. Scroll up to the first report in the Approve status
4. Tap on the Pay button from the preview
5. Select the option Mark as paid

Expected Result:

Workspace chat remains at the report preview after the admin "Mark as paid" it, and the report gets highlighted

Actual Result:

Workspace chat auto scrolls down to the latest out of the report preview after the admin "Mark as paid" an expense, and the last report gets highlighted

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021989156749367399747
• Upwork Job ID: 1989156749367399747
• Last Price Increase: 2025-11-28

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace chat auto scrolls down to the latest out of the report preview after the admin "Mark as paid" an expense, and the last report gets highlighted

What is the root cause of that problem?

We notify newest action to the topmost reportID which is the workspace chat

App/src/libs/actions/IOU.ts

Line 11213 in 1e2c61e

notifyNewAction(Navigation.getTopmostReportId() ?? iouReport?.reportID, userAccountID);

What changes do you think we should make in order to solve the problem?

We should only notify the newest action to the iou report. I don't think this is a correct expected and the report gets highlighted since the highlight behavior only happens when we scroll to another action.

notifyNewAction(iouReport?.reportID, userAccountID); 

App/src/libs/actions/IOU.ts

Line 11213 in 1e2c61e

notifyNewAction(Navigation.getTopmostReportId() ?? iouReport?.reportID, userAccountID);

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[abbasifaizan70]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace chat auto scrolls down to the latest message (out of the report preview) after the admin marks a report as paid, and the last report gets highlighted instead of the paid report.

What is the root cause of that problem?

When payMoneyRequest is called, it notifies a new action but doesn't pass the reportPreviewAction as the third parameter to notifyNewAction. This causes the scroll callback in ReportActionsList.tsx to not receive the action details.

https://github.com/Expensify/App/blob/1e2c61e5db88e0360c02f28ada1f8fa9fb7de65a/src/libs/actions/IOU.ts#L11231

notifyNewAction(Navigation.getTopmostReportId() ?? iouReport?.reportID, userAccountID);

In ReportActionsList.tsx, the scrollToBottomForCurrentUserAction callback checks if the action is a REPORT_PREVIEW type to determine scroll behavior:

https://github.com/Expensify/App/blob/1e2c61e5db88e0360c02f28ada1f8fa9fb7de65a/src/pages/home/report/ReportActionsList.tsx#L538-L549

if (action?.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW) {
    if (index > 0) {
        setTimeout(() => {
            reportScrollManager.scrollToIndex(index);
        }, 100);
    } else {
        setIsFloatingMessageCounterVisible(false);
        reportScrollManager.scrollToBottom();
    }
    if (action?.reportActionID) {
        setActionIdToHighlight(action.reportActionID);
    }
}

Without the action parameter, this logic is skipped and the else branch executes (line 551), which scrolls to bottom.

What changes do you think we should make in order to solve the problem?

We should pass the reportPreviewAction to notifyNewAction so the scroll logic can identify the specific report preview that was paid and scroll to it correctly.

In src/libs/actions/IOU.ts, line 11231:

Change:

notifyNewAction(Navigation.getTopmostReportId() ?? iouReport?.reportID, userAccountID);

To:

const reportID = Navigation.getTopmostReportId() ?? iouReport?.reportID;
const reportPreviewAction = getReportPreviewAction(chatReport.reportID, iouReport?.reportID);
notifyNewAction(reportID, userAccountID, reportPreviewAction ?? undefined);

This ensures the report preview action is passed to the scroll handler, which will then:

1. Find the correct index of the paid report preview in the chat
2. Scroll to that specific report preview
3. Highlight the correct report (the one that was just paid)

What alternative solutions did you explore?

An alternative would be to always notify the iou report instead of the chat report (using iouReport?.reportID instead of topmost report). However, this wouldn't work because:

1. The user is viewing the workspace chat, not the IOU report
2. The report preview action exists in the chat report's actions, not the IOU report
3. We need to trigger the scroll behavior in the currently visible chat

The current solution maintains the existing behavior of notifying the topmost report (which is correct) while providing the necessary action information for proper scrolling.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021989156749367399747

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)