[$250] SendInvoice reports cannot be deleted when created in offline mode

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.43-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @suneox
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Precondition: Workspace has invite members and enabled workflow and invoice features

1. Turn off network connection
2. Navigate to FAB → SendInvoice
3. Enter amount
4. Select member from workspace
5. Send from workspace that has enabled workflow and invoice features
6. Open details of the created invoice
7. Open the secondary actions menu

Expected Result:

The delete button should be available for SendInvoice reports when the user is the owner, maintaining consistency with RequestMoney reports which can be deleted offline.

Actual Result:

The delete button is not available for SendInvoice reports when created offline. Users cannot delete invoices they created in offline mode,

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2025-11-04.at.01.15.07.mp4

Recording.1881.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021988348453018964273
• Upwork Job ID: 1988348453018964273
• Last Price Increase: 2025-11-11

Issue Owner

Current Issue Owner: @suneox

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[suneox]

Forwarding the proposal

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users cannot delete invoices when they are created in offline mode. The delete button is not available for SendInvoice reports when the app is offline, even though the user is the owner of the invoice. This creates an inconsistent user experience where RequestMoney (IOU) reports can be deleted offline but SendInvoice (Invoice) reports cannot.

What is the root cause of that problem?

The root cause is in the canDeleteMoneyRequestReport function. The invoice deletion logic relies on isReportOpenOrProcessing which isOpenReport or isProcessingReport to check if the report is in OPEN or SUBMITTED state. However, when creating invoices the report can be in an inconsistent transition state where stateNum is SUBMITTED but statusNum is still OPEN, causing isReportOpenOrProcessing to return false.

What changes do you think we should make in order to solve the problem?

We can modify the buildOptimisticInvoiceReport function to set consistent state values for initial invoices to match other workflows

App/src/libs/ReportUtils.ts

Lines 6481 to 6482 in 7382906

	stateNum: CONST.REPORT.STATE_NUM.SUBMITTED,
	statusNum: CONST.REPORT.STATUS_NUM.OPEN,

// Fixed code (consistent state):
stateNum: CONST.REPORT.STATE_NUM.OPEN,       // Set to 0 instead of 1
statusNum: CONST.REPORT.STATUS_NUM.OPEN,     // Set to 0

Or set the initial value to match the backend result, using SUBMITTED instead of OPEN.

What alternative solutions did you explore? (Optional)

** Edge Case Handling in Deletion Logic**
Handle the inconsistent state in the canDeleteMoneyRequestReport function by adding specific checks for creating invoices.

if (isInvoiceReport(report)) {
    const isOwnerMatch = report?.ownerAccountID === currentUserAccountID;
    let canDelete = isOwnerMatch && isReportOpenOrProcessing;

    // Handle edge cases for creating invoices
    if (isOwnerMatch && !isReportOpenOrProcessing) {
        const hasValidStateForDeletion =
            (report?.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && report?.statusNum === CONST.REPORT.STATUS_NUM.OPEN);

        if (hasValidStateForDeletion) {
            canDelete = true;
        }
    }
    return canDelete;
}

[hasib711]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The delete button should be available for SendInvoice reports when the user is the owner, maintaining consistency with RequestMoney reports which can be deleted offline.

What is the root cause of that problem?

We check more button list using this code

App/src/libs/ReportSecondaryActionUtils.ts

Lines 687 to 689 in 183beed

	if (isDeleteAction(report, reportTransactions, reportActions ?? [], policy)) {
	options.push(CONST.REPORT.SECONDARY_ACTIONS.DELETE);
	}

App/src/libs/ReportSecondaryActionUtils.ts

Lines 460 to 462 in 183beed

	function isDeleteAction(report: Report, reportTransactions: Transaction[], reportActions: ReportAction[], policy?: Policy): boolean {
	return canDeleteMoneyRequestReport(report, reportTransactions, reportActions, policy);
	}

When offline, if send invoice, stateNum and statusnum of report is not equal.
So this report isn't processing status.

App/src/libs/ReportUtils.ts

Line 2739 in 183beed

const isReportOpenOrProcessing = isOpenReport(report) || isProcessingReport(report);

App/src/libs/ReportUtils.ts

Lines 2752 to 2754 in 183beed

	if (isInvoiceReport(report)) {
	return report?.ownerAccountID === currentUserAccountID && isReportOpenOrProcessing;
	}

What changes do you think we should make in order to solve the problem?

When we open report, if report was created offline, response is "not found report"
So statusNum and stateNum of report is init to open status.

App/src/libs/actions/Report.ts

Line 1018 in 183beed

function openReport(

failureData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
            value: {
                stateNum: CONST.REPORT.STATE_NUM.OPEN,
                statusNum: CONST.REPORT.STATUS_NUM.OPEN,
            },
        })

What alternative solutions did you explore? (Optional)

[melvin-bot]

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021988348453018964273

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)