[Due for payment 2025-12-05] [$250] Invited member to expense report sees the chat with fallback avatar on LHN

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.42-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): gocemate+b2154894@gmail.com
Issue reported by: Applause Internal Team
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Submit two expenses to User B.
3. [User A] Go to the expense report.
4. [User A] Send a message containing User C mention.
5. [User A] Invite User C by clicking Invite them on the whisper.
6. [User C] Check when chat appears on LHN

Expected Result:

There should be default avatar

Actual Result:

When User C is invited to expenses report - chat with fallback avatar appears on LHN

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021985871265504738354
• Upwork Job ID: 1985871265504738354
• Last Price Increase: 2025-11-05

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mukhrr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invited member to expense report sees the chat with fallback avatar on LHN

What is the root cause of that problem?

We miss avatar when building optimistic data of a user here

App/src/libs/PersonalDetailsUtils.ts

Lines 208 to 213 in 7cc5fb0

	personalDetailsNew[accountID] = {
	login,
	accountID,
	displayName: formatPhoneNumber(login),
	isOptimisticPersonalDetail: true,
	};

What changes do you think we should make in order to solve the problem?

We need to add avatar

        personalDetailsNew[accountID] = {
            login,
            accountID,
            avatar: getDefaultAvatarURL(accountID, login),
            displayName: formatPhoneNumber(login),
            isOptimisticPersonalDetail: true,
        };

And also fix should return correct optimistic and finally data test in getPersonalDetailsOnyxDataForOptimisticUsers block inside tests/unit/libs/PersonalDetailsUtilsTest.ts

            const expected = {
                optimisticData: [
                    {
                        key: ONYXKEYS.PERSONAL_DETAILS_LIST,
                        onyxMethod: 'merge',
                        value: {
                            // eslint-disable-next-line @typescript-eslint/naming-convention
                            '1': {
                                accountID: 1,
                                avatar: 'https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_15.png',
                                displayName: '3322076524',
                                isOptimisticPersonalDetail: true,
                                login: '3322076524',
                            },
                            // eslint-disable-next-line @typescript-eslint/naming-convention
                            '2': {
                                accountID: 2,
                                avatar: 'https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_18.png',
                                displayName: 'test2@test.com',
                                isOptimisticPersonalDetail: true,
                                login: 'test2@test.com',
                            },
                            // eslint-disable-next-line @typescript-eslint/naming-convention
                            '3': {
                                accountID: 3,
                                avatar: 'https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_6.png',
                                displayName: '(418) 543-8090',
                                isOptimisticPersonalDetail: true,
                                login: '+14185438090',
                            },
                        },
                    },
                ],

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021985871265504738354

[greg-schroeder]

Sending through to External

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)