[Due for payment 2025-11-26] [$250] Expense-Create expense option is shown in paid expense details page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.42-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1661/folder/13176924/41237585/987478631
Email or phone of affected tester (no customers): Slottwo1 72old.approver@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Login with new gmail account
3. Tap fab - scan - try it out
4. Tap create expense
5. Open the paid expense
6. Tap plus icon
7. Tap create expense and complete the flow
8. Go to main chat page

Expected Result:

Create expense option must not be shown in paid expense details page.

Actual Result:

Create expense option is shown in paid expense details page and user allowed to create expense from paid expense details page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021985791222665493554
• Upwork Job ID: 1985791222665493554
• Last Price Increase: 2025-11-11

Issue Owner

Current Issue Owner: @NicMendonca

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Create expense option is shown in paid expense details page and user allowed to create expense from paid expense details page.

What is the root cause of that problem?

The getMoneyRequestOptions function was not checking if the current report is a settled money request report before returning available expense creation options. It misses the Settled/paid money request reports (IOU reports with statusNum === REIMBURSED)

App/src/libs/ReportUtils.ts

Lines 9271 to 9292 in 8dedd67

	function getMoneyRequestOptions(
	report: OnyxEntry<Report>,
	policy: OnyxEntry<Policy>,
	reportParticipants: number[],
	filterDeprecatedTypes = false,
	isReportArchived = false,
	isRestrictedToPreferredPolicy = false,
	): IOUType[] {
	const teacherUnitePolicyID = environment === CONST.ENVIRONMENT.PRODUCTION ? CONST.TEACHERS_UNITE.PROD_POLICY_ID : CONST.TEACHERS_UNITE.TEST_POLICY_ID;
	const isTeachersUniteReport = report?.policyID === teacherUnitePolicyID;
	// In any thread, task report or trip room, we do not allow any new expenses
	if (isChatThread(report) || isTaskReport(report) || isInvoiceReport(report) || isSystemChat(report) || isReportArchived || isTripRoom(report)) {
	return [];
	}
	if (isInvoiceRoom(report)) {
	if (canSendInvoiceFromWorkspace(policy?.id) && isPolicyAdmin(report?.policyID, allPolicies)) {
	return [CONST.IOU.TYPE.INVOICE];
	}
	return [];
	}

What changes do you think we should make in order to solve the problem?

We should add a check to return an empty array when the report is a money request report that cannot accept new transactions (i.e., it's settled/paid).

    // Don't allow adding expenses to a settled/paid money request report
    if (isMoneyRequestReport(report) && !canAddTransaction(report, isReportArchived)) {
        return [];
    }

App/src/libs/ReportUtils.ts

Line 9286 in 8dedd67

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Create expense is shown in the paid manager mctest expense report.

What is the root cause of that problem?

We already check whether we can request money or not before adding the option, which returns false for settled report.

App/src/libs/ReportUtils.ts

Lines 9499 to 9512 in 515655a

	if (canRequestMoney(report, policy, otherParticipants)) {
	// For Teachers Unite policy, don't show Create Expense option
	if (!isTeachersUniteReport) {
	options = [...options, CONST.IOU.TYPE.SUBMIT];
	if (!filterDeprecatedTypes) {
	options = [...options, CONST.IOU.TYPE.REQUEST];
	}
	}
	// If the user can request money from the workspace report, they can also track expenses
	if (isPolicyExpenseChat(report) || isExpenseReport(report)) {
	options = [...options, CONST.IOU.TYPE.TRACK];
	}
	}

App/src/libs/ReportUtils.ts

Lines 9412 to 9414 in 515655a

	if (isMoneyRequestReport(report)) {
	return canAddTransaction(report);
	}

App/src/libs/ReportUtils.ts

Lines 2565 to 2567 in 515655a

	if (isReportApproved({report: moneyRequestReport}) || isClosedReport(moneyRequestReport) || isSettled(moneyRequestReport?.reportID)) {
	return false;
	}

But we also have a logic that if it's a report with expensify account as participant, we won't allow request money, except for manager mctest.

App/src/libs/ReportUtils.ts

Lines 9477 to 9489 in 515655a

	// We don't allow IOU actions if an Expensify account is a participant of the report, unless the policy that the report is on is owned by an Expensify account
	const doParticipantsIncludeExpensifyAccounts = lodashIntersection(reportParticipants, CONST.EXPENSIFY_ACCOUNT_IDS).length > 0;
	// This will be fixed as part of https://github.com/Expensify/Expensify/issues/507850
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	const policyOwnerAccountID = getPolicy(report?.policyID)?.ownerAccountID;
	const isPolicyOwnedByExpensifyAccounts = policyOwnerAccountID ? CONST.EXPENSIFY_ACCOUNT_IDS.includes(policyOwnerAccountID) : false;
	if (doParticipantsIncludeExpensifyAccounts && !isPolicyOwnedByExpensifyAccounts) {
	// Allow create expense option for Manager McTest report
	if (reportParticipants.some((accountID) => accountID === CONST.ACCOUNT_ID.MANAGER_MCTEST) && Permissions.isBetaEnabled(CONST.BETAS.NEWDOT_MANAGER_MCTEST, allBetas)) {
	return [CONST.IOU.TYPE.SUBMIT];
	}
	return [];
	}

This was added in #58729 to allow the user to add an expense to the manager mctest chat report. But this also allows the user to add in the paid/settled expense report.

What changes do you think we should make in order to solve the problem?

We can add a check whether it's a chat report or not.

if (isChatReport(report) && reportParticipants.some((accountID) => accountID === CONST.ACCOUNT_ID.MANAGER_MCTEST) && Permissions.isBetaEnabled(CONST.BETAS.NEWDOT_MANAGER_MCTEST, allBetas)) {
    return [CONST.IOU.TYPE.SUBMIT];
}

OR

Use canRequestMoney here too.

if (canRequestMoney(report, policy, otherParticipants) && reportParticipants.some((accountID) => accountID === CONST.ACCOUNT_ID.MANAGER_MCTEST) && Permissions.isBetaEnabled(CONST.BETAS.NEWDOT_MANAGER_MCTEST, allBetas)) {
    return [CONST.IOU.TYPE.SUBMIT];
}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021985791222665493554

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[dukenv0307]

Thanks for all your proposals. @bernhardoj's root cause is correct and the solution makes sense to me.

@lorretheboy Even when canRequestMoney returns false, we still show other options, so early return empty is wrong.

Let's go with @bernhardoj's proposal

🎀👀🎀 C+ reviewed