[Due for payment 2025-11-21] [$250] Expense - Report field is clickable for workspace chat member which leads to not here page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.42-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #73768
Email or phone of affected tester (no customers): jnoijoijoinjojoijnioj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace has at least one Report field (create it on workspace settings > Reports).

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an report.
4. Open the report.
5. Mention user B and send the message.
6. Click Invite to chat only.
7. Open the invited report as User B.
8. Click on the report field.

Expected Result:

Report field should be read-only for User B.

Actual Result:

Report field is clickable for workspace chat member which leads to not here page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6990696_1761948121291.5.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021985740715510231530
• Upwork Job ID: 1985740715510231530
• Last Price Increase: 2025-11-04

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mitarachim]

Issue was found while executing QA for PR #73768

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Report field is clickable for workspace chat member which leads to not here page

What is the root cause of that problem?

We add the check only for MoneyRequest, but we do not add this check for Report here:

App/src/components/MoneyRequestReportView/MoneyRequestViewReportFields.tsx

Line 98 in 515655a

const isFieldDisabled = isReportFieldDisabled(report, field, policy);

What changes do you think we should make in order to solve the problem?

We need to add a check for isAdminOwnerApproverOrReportOwner and hide violation in this case:

const isFieldDisabled = isReportFieldDisabled(report, field, policy) || !isAdminOwnerApproverOrReportOwner(report, policy);

const violation = isFieldDisabled ? undefined : getFieldViolation(violations, field);

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[hasib711]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Report field is clickable for workspace chat member which leads to not here page

What is the root cause of that problem?

We check for EditReportPage:

App/src/pages/EditReportFieldPage.tsx

Lines 45 to 69 in 515655a

	const isDisabled = isReportFieldDisabled(report, reportField, policy) || !isAdminOwnerApproverOrReportOwner(report, policy);
	const {isBetaEnabled} = usePermissions();
	const isASAPSubmitBetaEnabled = isBetaEnabled(CONST.BETAS.ASAP_SUBMIT);
	const session = useSession();
	const [transactionViolations] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, {canBeMissing: true});
	const hasViolations = hasViolationsReportUtils(report?.reportID, transactionViolations);
	const [isDeleteModalVisible, setIsDeleteModalVisible] = useState(false);
	const {translate} = useLocalize();
	const isReportFieldTitle = isReportFieldOfTypeTitle(reportField);
	const reportFieldsEnabled = ((isPaidGroupPolicyExpenseReport(report) || isInvoiceReport(report)) && !!policy?.areReportFieldsEnabled) || isReportFieldTitle;
	const hasOtherViolations =
	report?.fieldList && Object.entries(report.fieldList).some(([key, field]) => key !== fieldKey && field.value === '' && !isReportFieldDisabled(report, reportField, policy));
	if (!reportFieldsEnabled || !reportField || !policyField || !report || isDisabled) {
	return (
	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	shouldEnableMaxHeight
	testID={EditReportFieldPage.displayName}
	>
	<FullPageNotFoundView shouldShow />
	</ScreenWrapper>
	);
	}

What changes do you think we should make in order to solve the problem?

const isDisabled = isReportFieldDisabled(report, reportField, policy);

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021985740715510231530

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (External)