[Due for payment 2026-01-15] [To-do counters] Deprecate SearchTransaction & Cleanup

[luacmartins]

Release 1: Align Snapshot and Live Onyx data types
We'll begin by aligning the snapshot and live Onyx data types. Each of the keys below will be addressed in individual issues that will be worked on in parallel by external contributors. Here's the plan to deprecate each key in Search* types in favor of those in onyx/types/

Deprecate SearchTransaction & Cleanup

1. In App, remove SearchTransaction
2. Bump the minimum App version to the version of the last SearchTransaction deprecation PR
3. In Auth, remove the following instances:
   1. accountID in buildTransactionResponse and from the query
   2. managerID in buildTransactionResponse and from the query
   3. reportType from the response in buildTransactionResponse
   4. policyID from the response in buildTransactionResponse
   5. hasViolation from the response in buildTransactionResponse
   6. transactionThreadReportID from the response in buildTransactionResponse
   7. transactionThreadReportID from the response in buildTransactionResponse
   8. transactionThreadReportID from the response in buildTransactionResponse
   9. canHold from the response in buildTransactionResponse
   10. canUnhold from the response in buildTransactionResponse
   11. canDelete from the response in buildTransactionResponse
   12. isFromOneTransactionReport from the response in buildTransactionResponse

Parent Issue: https://github.com/Expensify/Expensify/issues/563552

Issue Owner

Current Issue Owner: @CortneyOfstad

[hasib711]

I would like to work on this issue, if it is open for external contributors.

[PiyushChandra17]

I would like to work on this, the solution is already detailed in OP

[luacmartins]

Future release

[luacmartins]

Future release