[To-do counters] SearchTransaction > transactionType

[luacmartins]

Release 1: Align Snapshot and Live Onyx data types
We'll begin by aligning the snapshot and live Onyx data types. Each of the keys below will be addressed in individual issues that will be worked on in parallel by external contributors. Here's the plan to deprecate each key in Search* types in favor of those in onyx/types/

SearchTransaction > transactionType

1. In App, create a new function getTransactionType, which will:
   1. If transaction.comment.customUnit.name === 'Distance', return distance
   2. If transaction.comment.customUnit.name === 'Per Diem International', return perDiem
   3. If cardList[transaction.cardID].cardName === '__CASH__', return cash
   4. Otherwise return card
2. Remove transactionType
3. Run npm run typecheck. Fix any errors by replacing the calls to transaction.transactionType with getTransactionType
4. In Auth, remove these lines from the query

Parent Issue: https://github.com/Expensify/Expensify/issues/563552

[Burhan-Rashid]

I would like to work on this issue, if this is open for external contributors.

[PiyushChandra17]

I would like to work on this, the solution is already detailed in OP

[DylanDylann]

@luacmartins Please assign me to this issue