[Due for payment 2025-12-17] [To-do counters] SearchTransaction > moneyRequestReportActionID

[luacmartins]

Release 1: Align Snapshot and Live Onyx data types
We'll begin by aligning the snapshot and live Onyx data types. Each of the keys below will be addressed in individual issues that will be worked on in parallel by external contributors. Here's the plan to deprecate each key in Search* types in favor of those in onyx/types/

SearchTransaction > moneyRequestReportActionID

1. In App, remove moneyRequestReportActionID
2. Run npm run typecheck. Fix any errors by replacing the calls to transaction.moneyRequestReportActionID with getIOUActionForTransactionID

Parent Issue: https://github.com/Expensify/Expensify/issues/563552

[mohammadjafarinejad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove moneyRequestReportActionID from SearchTransaction and replace calls with getIOUActionForTransactionID.

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?

1. Remove moneyRequestReportActionID from SearchTransaction type in src/types/onyx/SearchResults.ts
2. Find all usages of transaction.moneyRequestReportActionID and replace with getIOUActionForTransactionID helper
3. Update test files to remove moneyRequestReportActionID from mock data

What alternative solutions did you explore? (Optional)

None

[PiyushChandra17]

I would like to work on this, the solution is already detailed in OP

[annaweber830]

I'm already working on this

[luacmartins]

@annaweber830 You're only assigned to #73963. Please work on the changes for that issue only!

[DylanDylann]

@luacmartins Please assign me to this issue