[Due for payment 2025-11-21] [$250] Split confirm page shows arrow buttons after opening split preview and creating a new split

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.39-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): sdjionsdjosijnsodi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Create a group chat with two users.
3. Click + > Split expense > Manual.
4. Create a split manual expense.
5. Click on the split preview.
6. Click outside RHP to close it.
7. Click + > Split expense > Manual.
8. Enter amount > Next.
9. Click < arrow button on confirm page.

Expected Result:

There should be no arrow buttons on confirm page because there is only one split manual expense.

Actual Result:

There are arrow buttons on confirm page when there is only one split manual expense.
The first split shows split with self with 0.00 amount.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6986495_1761628344319.Screen_Recording_2025-10-28_at_13.08.20.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021983262511049916907
• Upwork Job ID: 1983262511049916907
• Last Price Increase: 2025-10-28
• Automatic offers:
• etCoderDysto | Contributor | 109346001

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split confirm page shows arrow buttons after opening split preview and creating a new split

What is the root cause of that problem?

When opening the split expense detail, we call setMoneyRequestTaxRate add draftTransaction to onyx with the transactionID as a key

App/src/components/MoneyRequestConfirmationList.tsx

Lines 337 to 341 in 805a21f

	useEffect(() => {
	if (!transactionID) {
	return;
	}
	setMoneyRequestTaxRate(transactionID, defaultTaxCode);

Then when we try to create another split expense, we will add another draft transaction to onyx. And the number of draft transaction will be greater than 1. And show PrevNextButtons when optimisticTransactions.length is greater than one

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 1164 to 1166 in 805a21f

	{hasMultipleTransactions ? (
	<PrevNextButtons
	isPrevButtonDisabled={currentTransactionIndex === 0}

What changes do you think we should make in order to solve the problem?

We should return early before calling setMoneyRequestTaxRate if we are not editing on MoneyRequestConfirmationList page here

    useEffect(() => {
        if (!transactionID || isReadOnly) {
            return;
        }
        setMoneyRequestTaxRate(transactionID, defaultTaxCode);
    }, [defaultTaxCode, transactionID, isReadOnly]);

We should do the same before we call too setMoneyRequestTaxAmount

App/src/components/MoneyRequestConfirmationList.tsx

Lines 482 to 487 in 805a21f

	useEffect(() => {
	if (!transactionID) {
	return;
	}
	setMoneyRequestTaxAmount(transactionID, taxAmountInSmallestCurrencyUnits);
	}, [transactionID, taxAmountInSmallestCurrencyUnits]);

What alternative solutions did you explore? (Optional)

We can filter out draft transactions that doesn't have amount property on them here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 124 to 127 in 805a21f

	const transactions = useMemo(() => {
	const allTransactions = optimisticTransactions && optimisticTransactions.length > 1 ? optimisticTransactions : [initialTransaction];
	return allTransactions.filter((transaction): transaction is Transaction => !!transaction);
	}, [initialTransaction, optimisticTransactions]);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021983262511049916907

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

@allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allroundexperts]

@etCoderDysto's proposal looks good to me.

🎀 👀 🎀 C+ reviewed