[Due for payment 2025-11-21] [$250] LHN - GBR persist on Concierge chat when mark all tasks completed in offline mode

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.36-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1422/folder/13176677/41237661/965870162
Email or phone of affected tester (no customers): gocemate+b2154660@gmail.com
Issue reported by: Applause Internal Team
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Create a new user
2. Select "Chat and split expenses with friends" from onboarding modal and complete the process
3. Go offline
4. Go to Concierge chat and manually complete all tasks

Expected Result:

There should be no GBR on Concierge chat in LHN

Actual Result:

GBR persist on Concierge chat when mark all tasks completed in offline mode

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021981442222724623730
• Upwork Job ID: 1981442222724623730
• Last Price Increase: 2025-10-23
• Automatic offers:
• situchan | Reviewer | 109239405
• mkzie2 | Contributor | 109239408

Issue Owner

Current Issue Owner: @situchan

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

GBR persist on Concierge chat when mark all tasks completed in offline mode

What is the root cause of that problem?

We have the logic to update hasOutstandingChildTask in optimistic here

App/src/libs/actions/Task.ts

Lines 422 to 438 in caee101

	if (parentReport?.hasOutstandingChildTask) {
	const hasOutstandingChildTask = getOutstandingChildTask(taskReport);
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${taskReport?.parentReportID}`,
	value: {
	hasOutstandingChildTask,
	},
	});
	failureData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${taskReport?.parentReportID}`,
	value: {
	hasOutstandingChildTask: parentReport?.hasOutstandingChildTask,
	},
	});
	}

getOutstandingChildTask function is checking childStateNum and childStatusNum from parent report action but we don't update this data in optimistic data when completing the task then this function still returns true and GBR persists in LHN.

App/src/libs/actions/Task.ts

Lines 345 to 360 in caee101

	/**
	* @returns the object to update `report.hasOutstandingChildTask`
	*/
	function getOutstandingChildTask(taskReport: OnyxEntry<OnyxTypes.Report>) {
	const parentReportActions = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${taskReport?.parentReportID}`] ?? {};
	return Object.values(parentReportActions).some((reportAction) => {
	if (String(reportAction.childReportID) === String(taskReport?.reportID)) {
	return false;
	}
	if (
	reportAction.childType === CONST.REPORT.TYPE.TASK &&
	reportAction?.childStateNum === CONST.REPORT.STATE_NUM.OPEN &&
	reportAction?.childStatusNum === CONST.REPORT.STATUS_NUM.OPEN &&
	!ReportActionsUtils.getReportActionMessage(reportAction)?.isDeletedParentAction
	) {

What changes do you think we should make in order to solve the problem?

We should update childStateNum, childStatusNum of parent report action in optimistic data

const parentReportAction = getParentReportAction(taskReport);
    if (parentReportAction) {
        optimisticData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReport?.reportID}`,
            value: {[parentReportAction.reportActionID]: {
                childStateNum: CONST.REPORT.STATE_NUM.APPROVED,
                childStatusNum: CONST.REPORT.STATUS_NUM.APPROVED,
            }},
        });

        failureData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReport?.reportID}`,
            value: {[parentReportAction.reportActionID]: {
                childStateNum: CONST.REPORT.STATE_NUM.OPEN,
                childStatusNum: CONST.REPORT.STATUS_NUM.OPEN,
            }},
        });
    }

App/src/libs/actions/Task.ts

Lines 422 to 438 in caee101

	if (parentReport?.hasOutstandingChildTask) {
	const hasOutstandingChildTask = getOutstandingChildTask(taskReport);
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${taskReport?.parentReportID}`,
	value: {
	hasOutstandingChildTask,
	},
	});
	failureData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${taskReport?.parentReportID}`,
	value: {
	hasOutstandingChildTask: parentReport?.hasOutstandingChildTask,
	},
	});
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update completeTask to verify that childStateNum and childStatusNum are updated.

What alternative solutions did you explore? (Optional)

We can get the task report and check stateNum and statusNum first if the report exists.

App/src/libs/actions/Task.ts

Lines 345 to 360 in caee101

	/**
	* @returns the object to update `report.hasOutstandingChildTask`
	*/
	function getOutstandingChildTask(taskReport: OnyxEntry<OnyxTypes.Report>) {
	const parentReportActions = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${taskReport?.parentReportID}`] ?? {};
	return Object.values(parentReportActions).some((reportAction) => {
	if (String(reportAction.childReportID) === String(taskReport?.reportID)) {
	return false;
	}
	if (
	reportAction.childType === CONST.REPORT.TYPE.TASK &&
	reportAction?.childStateNum === CONST.REPORT.STATE_NUM.OPEN &&
	reportAction?.childStatusNum === CONST.REPORT.STATUS_NUM.OPEN &&
	!ReportActionsUtils.getReportActionMessage(reportAction)?.isDeletedParentAction
	) {

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021981442222724623730

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[situchan]

@mkzie2's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.