[Due for payment 2025-12-05] [$250] Workspace - Company name instead of Reconciliation bank account name

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.2.32-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72543
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Device used: MacOS Catalina 10.15.7 / Chrome
App Component: Other

Action Performed:

Precondition: workspace with enabled Expensify card, two bank accounts and connected Accounting integration (e.g. Netsuite)

Go to WS > Accounting
Click on Card reconciliation
Turn on toggle Continuous Reconciliation

Expected Result:

The list on the ReconciliationAccountSettingsPage consist bank account names (e.g. Plaid Savings, Plaid Checking)

Actual Result:

The list on the ReconciliationAccountSettingsPage consist company names - Alberta Bobbeth Charleson, which makes indeterminacy which account to choose.

Workaround:

Unknown

Platforms:

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021980574704594726344
Upwork Job ID: 1980574704594726344
Last Price Increase: 2025-11-11
Automatic offers:

daledah | Contributor | 109588429

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

🚨 Edited by proposal-police: This proposal was edited at 2025-10-22 16:29:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The list on the ReconciliationAccountSettingsPage consist company names - Alberta Bobbeth Charleson, which makes indeterminacy which account to choose.

What is the root cause of that problem?

We're using bank account title here:

App/src/pages/workspace/accounting/reconciliation/ReconciliationAccountSettingsPage.tsx

Line 59 in 12d04ee

text: bankAccount.title,

Some bank account have different number but have the same title.

What changes do you think we should make in order to solve the problem?

To better distinguish different account title and account number, we should add an alternate text showing account number:

App/src/pages/workspace/accounting/reconciliation/ReconciliationAccountSettingsPage.tsx

Lines 58 to 63 in 12d04ee

    
           return eligibleBankAccounts.map((bankAccount, index) => ({ 
        
               text: bankAccount.title, 
        
               value: bankAccount.accountData?.bankAccountID, 
        
               keyForList: bankAccount.accountData?.bankAccountID?.toString() ?? `${bankAccount.title}-${index}`, 
        
               isSelected: bankAccount.accountData?.bankAccountID === paymentBankAccountID, 
        
           }));

alternateText: bankAccount.description ?? (bankAccount.accountData?.accountNumber ? `${translate('bankAccount.accountEnding')} ${getLastFourDigits(bankAccount.accountData.accountNumber)}` : ''),

We can use different translation, this can be discussed further in the PR phase.

To use the new list item, replace RadioListItem with SingleSelectListItem, with some tweaks to match the design styles.

App/src/pages/workspace/accounting/reconciliation/ReconciliationAccountSettingsPage.tsx

Line 101 in 14329cd

ListItem={RadioListItem}

Note: We don't store each account's name, this information is available only when adding bank account flow. I think this is expected for security reasons. So we have the only option to display in account number last four.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

🚨 Edited by proposal-police: This proposal was edited at 2025-10-22 15:09:43 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace accounting screens show confusing bank names. When admins enable continuous reconciliation, the pickers list the workspace legal entity or card domain name instead of the real bank account label.

What is the root cause of that problem?

The bank selection lists read bankAccount.title, which stores the company name for these feeds rather than the connected bank nickname. See the existing mapper that feeds the reconciliation picker:

App/src/pages/workspace/accounting/reconciliation/ReconciliationAccountSettingsPage.tsx

Lines 52 to 65 in f8e2af1

    
           const sections = useMemo(() => { 
        
               if (!bankAccountList || isEmptyObject(bankAccountList)) { 
        
                   return []; 
        
               } 
        
               const eligibleBankAccounts = getEligibleBankAccountsForCard(bankAccountList); 
        
               const data = eligibleBankAccounts.map((bankAccount) => ({ 
        
                   text: bankAccount.title, 
        
                   value: bankAccount.accountData?.bankAccountID, 
        
                   keyForList: bankAccount.accountData?.bankAccountID?.toString(), 
        
                   isSelected: bankAccount.accountData?.bankAccountID === paymentBankAccountID, 
        
               })); 
        
               return [{data}]; 
        
           }, [bankAccountList, paymentBankAccountID]);

What changes do you think we should make in order to solve the problem?

Create a shared helper that builds a friendly display name for each bank account, and reuse it across every settlement-account list. The helper would contain multiple fallbacks so that if a particular data is not available, then we can use the next best available data to decide the name to be shown. Pair that primary label with the standard “Account ending in XXXX” secondary line so the picker matches the rest of the places where we show such options.

Key updates:

Add getBankAccountDisplayName in BankAccountUtils to normalize names once.
Swap each selection list to call that helper when setting the option text or title.
Include the masked last four digits (alternate text / description) alongside the friendly label.
Update the reconciliation summary card to use the same helper so the label stays consistent across screens.

// src/libs/BankAccountUtils.ts
const ACCOUNT_NAME_KEYWORDS = ['checking', 'savings', 'account'];

function getBankAccountDisplayName(bankAccount: OnyxTypes.BankAccount | undefined, translate: TranslateFunction): string {
    if (!bankAccount) {
        return '';
    }

    const accountName = bankAccount.accountData?.addressName?.trim() ?? '';
    const lastFourDigits = getLastFourDigits(bankAccount.accountData?.accountNumber ?? '');
    const friendlyBankNames = CONST.BANK_NAMES_USER_FRIENDLY;
    const bankNameKey = bankAccount.accountData?.additionalData?.bankName;
    const bankName = bankNameKey ? friendlyBankNames?.[bankNameKey] ?? startCase(bankNameKey) : '';

    if (accountName) {
        const normalizedAccountName = accountName.toLowerCase();
        const includesKeyword = ACCOUNT_NAME_KEYWORDS.some((keyword) => normalizedAccountName.includes(keyword));
        const includesBankName = bankName ? normalizedAccountName.includes(bankName.toLowerCase()) : false;

        if (includesKeyword || includesBankName) {
            return accountName;
        }
    }

    if (bankName) {
        return bankName;
    }

    if (accountName) {
        return accountName;
    }

    if (lastFourDigits) {
        return `${translate('workspace.expensifyCard.accountEndingIn')} ${lastFourDigits}`;
    }

    return translate('common.bankAccount');
}

// src/pages/workspace/accounting/reconciliation/ReconciliationAccountSettingsPage.tsx
const sections = useMemo(() => {
    if (!bankAccountList || isEmptyObject(bankAccountList)) {
        return [];
    }
    const eligibleBankAccounts = getEligibleBankAccountsForCard(bankAccountList);

    const data = eligibleBankAccounts.map((bankAccount) => {
        const bankAccountNumber = bankAccount.accountData?.accountNumber ?? '';
        return {
            text: getBankAccountDisplayName(bankAccount, translate),
            alternateText: `${translate('workspace.expensifyCard.accountEndingIn')} ${getLastFourDigits(bankAccountNumber)}`,
            value: bankAccount.accountData?.bankAccountID,
            keyForList: bankAccount.accountData?.bankAccountID?.toString(),
            isSelected: bankAccount.accountData?.bankAccountID === paymentBankAccountID,
        };
    });
    return [{data}];
}, [bankAccountList, paymentBankAccountID, translate]);

Above logic can be discussed and improved during implementation.

We can consider using the same helper in WorkspaceSettlementAccountPage, WorkspaceExpensifyCardBankAccounts, CardReconciliationPage, and ChooseTransferAccountPage so every view shows the same friendly name.

Update: As per latest design comment, we can start using the radio list UI for this feature.

Job added to Upwork: https://www.upwork.com/jobs/~021980574704594726344

@akinwale

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@akinwale

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Company name instead of Reconciliation bank account name #75967

If no regressions arise, payment will be issued on 2025-12-05. 🎊

For reference, here are some details about the assignees on this issue:

@akinwale requires payment through NewDot Manual Requests
@daledah requires payment automatic offer (Contributor)

@akinwale

@akinwale @bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@akinwale

BugZero Checklist:

[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: N/A
[@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Workspace with Expensify card enabled, two or more bank accounts and a connected accounting integration (e.g. Netsuite)

Test:

Launch Expensify.
Navigate to Workspace settings > Accounting.
Click on Card reconciliation.
Turn on toggle Continuous Reconciliation.
Verify that there is an alternative text below the bank account name with the last 4 digits of the account number (Account ending in XXXX)

Do we agree 👍 or 👎?

Don't need a specific regression test for just this case.

awaiting payment

@akinwale

Payment summary:

@akinwale due $250 via NewDot Manual Requests
@daledah paid $250 via Upwork ✅

@akinwale

$250 approved for @akinwale

Navigation Menu

Repository navigation

[Due for payment 2025-12-05] [$250] Workspace - Company name instead of Reconciliation bank account name #72758

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

67 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	return eligibleBankAccounts.map((bankAccount, index) => ({
	text: bankAccount.title,
	value: bankAccount.accountData?.bankAccountID,
	keyForList: bankAccount.accountData?.bankAccountID?.toString() ?? `${bankAccount.title}-${index}`,
	isSelected: bankAccount.accountData?.bankAccountID === paymentBankAccountID,
	}));

	const sections = useMemo(() => {
	if (!bankAccountList \|\| isEmptyObject(bankAccountList)) {
	return [];
	}
	const eligibleBankAccounts = getEligibleBankAccountsForCard(bankAccountList);

	const data = eligibleBankAccounts.map((bankAccount) => ({
	text: bankAccount.title,
	value: bankAccount.accountData?.bankAccountID,
	keyForList: bankAccount.accountData?.bankAccountID?.toString(),
	isSelected: bankAccount.accountData?.bankAccountID === paymentBankAccountID,
	}));
	return [{data}];
	}, [bankAccountList, paymentBankAccountID]);

[Due for payment 2025-12-05] [$250] Workspace - Company name instead of Reconciliation bank account name #72758

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 16, 2025

daledah commented on Oct 16, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

ShridharGoel commented on Oct 16, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Oct 21, 2025

melvin-bot commented on Oct 21, 2025

67 remaining items

melvin-bot commented on Nov 28, 2025

melvin-bot commented on Nov 28, 2025

akinwale commented on Dec 3, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Julesssss commented on Dec 3, 2025

Julesssss commented on Dec 8, 2025

bfitzexpensify commented on Dec 11, 2025

JmillsExpensify commented on Dec 12, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions