[Due for payment 2025-12-04] [$250] Android - Report - "It´s not here" briefly seen when deleting report with more than one expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.31-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1291/folder/13176670/41237109/952580997
Email or phone of affected tester (no customers): ibellicotest+1924@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Money Requests

Action Performed:

Prerequisite: use Gmail account that has at least one workspace.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create two manual expenses.
4. Navigate to "Reports"
5. Tap on the link to workspace chat, on the report preview.
6. Once redirected to chat, long tap on report preview and delete it.
7. Note that a "It´s not here" page, briefly appears after report is deleted.

Expected Result:

Report should automatically disappear after being deleted.

Actual Result:

After deleting a report with more than one expense, after navigating to chat via link, a "It´s not here" page is briefly displayed.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021978922384042961776
• Upwork Job ID: 1978922384042961776
• Last Price Increase: 2025-10-16

Issue Owner

Current Issue Owner: @youssef-lr

[melvin-bot]

Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021978922384042961776

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[lorretheboy]

🚨 Edited by proposal-police: This proposal was edited at 2025-10-22 13:32:58 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting a report with more than one expense, after navigating to chat via link, a "It´s not here" page is briefly displayed.

What is the root cause of that problem?

When the report is deleted via the context menu here:

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

Lines 341 to 342 in cf26010

	} else if (isReportPreviewAction(reportAction)) {
	deleteAppReport(reportAction.childReportID);

The deleteAppReport function is called, which does the following in its optimistic data:

• Delete the iouReport
  

  App/src/libs/actions/Report.ts

  Lines 5210 to 5214 in 092472e

  	optimisticData.push({
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
  	value: null,
  	});

• Delete the report preview action entirely
  

  App/src/libs/actions/Report.ts

  Lines 5222 to 5243 in 092472e

  	// 8. Delete chat report preview
  	const reportActionID = report?.parentReportActionID;
  	const reportAction = allReportActions?.[reportID];
  	const parentReportID = report?.parentReportID;
  	if (reportActionID) {
  	optimisticData.push({
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`,
  	value: {
  	[reportActionID]: null,
  	},
  	});
  	failureData.push({
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`,
  	value: {
  	[reportActionID]: reportAction,
  	},
  	});
  	}

So why it wrong?

The report preview action is set to null instead of being marked with pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE which is different from deleteMoneyRequest, which sets pendingAction: DELETE on the report preview action

App/src/libs/actions/IOU.ts

Line 8632 in 092472e

value: {...transaction, pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE},

Therefore: The component re-renders with iouReport = undefined and action.pendingAction = undefined (because the action itself is being deleted)

MoneyRequestReportPreviewContent passes pendingAction={iouReport?.pendingFields?.preview} which evaluates to undefined

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Line 655 in 809575d

pendingAction={iouReport?.pendingFields?.preview}

Then OfflineWithFeedback does NOT hide the component because pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE

The component shows It's not here

Log:

What changes do you think we should make in order to solve the problem?

Update to pass action.pendingAction first, if it is not existed, then fall back to iouReport?.pendingFields?.preview

                pendingAction={action.pendingAction ?? iouReport?.pendingFields?.preview}

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Line 655 in 809575d

pendingAction={iouReport?.pendingFields?.preview}

What alternative solutions did you explore? (Optional)

Can make it consistent with deleteMoneyRequest

    // 8. Mark chat report preview action as deleted
    const reportActionID = report?.parentReportActionID;
    const parentReportID = report?.parentReportID;
    const parentReportAction = allReportActions?.[parentReportID ?? '']?.[reportActionID ?? ''];

    if (reportActionID && parentReportAction) {
        optimisticData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`,
            value: {
                [reportActionID]: {
                    pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
                },
            },
        });

        successData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`,
            value: {
                [reportActionID]: {
                    pendingAction: null,
                },
            },
        });

        failureData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`,
            value: {
                [reportActionID]: {
                    pendingAction: null,
                    errors: getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericDeleteFailureMessage'),
                },
            },
        });
    }

App/src/libs/actions/Report.ts

Lines 5222 to 5243 in 092472e

	// 8. Delete chat report preview
	const reportActionID = report?.parentReportActionID;
	const reportAction = allReportActions?.[reportID];
	const parentReportID = report?.parentReportID;
	if (reportActionID) {
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`,
	value: {
	[reportActionID]: null,
	},
	});
	failureData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`,
	value: {
	[reportActionID]: reportAction,
	},
	});
	}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[parasharrajat]

This mean the report preview is not being hidden immediately, causing a brief flash of the "It's not here" page as the user navigated away

@lorretheboy Can you explain how "It's not here" is shown in this case?