[Due for payment 2025-10-30] [$250] Report - Update action message appears when saving a report field without making any change

@Christinadobrzyn

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.2.31-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #72491
Email or phone of affected tester (no customers): htad26+reiuu@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: Workspace has a report field

Create a new report in the workspace
Open the report
Select the report field > Click "Save" without making any change
Observe the update action message
Again Select the report field > Click "Save" without making any change
Observe the update action message

Expected Result:

There shouldn't be any update action message since no change was made to the report field

Actual Result:

There is an update action message even if there is no change that was made to the report field

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

Platforms Tested:

On which of our officially supported platforms was this issue tested:

Screenshots/Videos

Add any screenshot/video evidence

Bug6974887_1760469294390.2025-10-14_22_04_31.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021978495918676366150
Upwork Job ID: 1978495918676366150
Last Price Increase: 2025-10-15

Issue Owner

Current Issue Owner: @Christinadobrzyn

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report - Update action message appears when saving a report field without making any change

What is the root cause of that problem?

Currently we always update field even it was not changed:

App/src/pages/EditReportFieldPage.tsx

Lines 78 to 99 in de62fd7

    
           const handleReportFieldChange = (form: FormOnyxValues<typeof ONYXKEYS.FORMS.REPORT_FIELDS_EDIT_FORM>) => { 
        
               const value = form[fieldKey]; 
        
               if (isReportFieldTitle) { 
        
                   updateReportName(report.reportID, value, report.reportName ?? ''); 
        
                   goBack(); 
        
               } else { 
        
                   if (value !== '') { 
        
                       updateReportField( 
        
                           {...report, reportID: report.reportID}, 
        
                           {...reportField, value}, 
        
                           reportField, 
        
                           policy as unknown as Policy, 
        
                           isASAPSubmitBetaEnabled, 
        
                           session?.accountID ?? CONST.DEFAULT_NUMBER_ID, 
        
                           session?.email ?? '', 
        
                           hasViolations, 
        
                           hasOtherViolations, 
        
                       ); 
        
                   } 
        
                   goBack(); 
        
               } 
        
           };

What changes do you think we should make in order to solve the problem?

We should add if to check if value is different from default(This can be done in both cases, or if the value is not isReportFieldTitle):

        if (fieldValue === value) {
            goBack();
return;
        }

PS: this condition can be improved if we want, like trim value, or maybe we already have function for that in project, that can be improved

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

I'm not getting the report field at all on the empty report. I'm testing on iOS and the video is on a browser... still testing

@Christinadobrzyn

Hi @Christinadobrzyn, i believe you need to create expense, not empty report, then you will get report fields at the top

PS: i mean issue is reproducible also this way

Job added to Upwork: https://www.upwork.com/jobs/~021978495918676366150

@eh2077

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

@Eskalifer1

This issue is straightforward. I think we can go with @Eskalifer1 's proposal!

🎀👀🎀 C+ reviewed

@fedirjh

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.36-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix:72626: call onClose during report field change if value didnt change #72952

If no regressions arise, payment will be issued on 2025-10-30. 🎊

For reference, here are some details about the assignees on this issue:

@fedirjh does not require payment (Contractor)
@Eskalifer1 requires $250 payment (Needs manual offer from BZ) Upwork offer - https://www.upwork.com/nx/wm/offer/109280614
@eh2077 requires $250 payment through NewDot Manual Requests

@eh2077

@eh2077 @Christinadobrzyn The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@eh2077

@eh2077 do we need a regression test for this? TY!

Moving this to daily since payment is coming up

@eh2077

@eh2077 do we need a regression test?

@fedirjh

Payment Summary

Upwork Job

Reviewer: @fedirjh does not require payment (Contractor)
ROLE: @Eskalifer1 paid $250 via Upwork - https://www.upwork.com/nx/wm/offer/109280614 PAID
Reviewer: @eh2077 owed $250 via NewDot

BugZero Checklist (@Christinadobrzyn)

(if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1978495918676366150/hired)
I have verified the PR was not reverted
I have applied any discounts due to bugs/regressions introduced by this PR
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

BugZero Checklist:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/34483/files#r2480146428
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue: [Due for payment 2025-10-30] [$250] Report - Update action message appears when saving a report field without making any change #72626 (comment)

Regression Test Proposal

Precondition:

Workspace has a report field

Test:

Create a new report in the workspace
Open the report
Enter a value and save (if the field is empty)
Select the report field > Click "Save" without making any change
Ensure that the update action message does not appear if the value has not changed.

Do we agree 👍 or 👎

@Christinadobrzyn

@Christinadobrzyn Thanks for the ping! Checklist done.

Thanks!

Regression test - #72626 (comment)

Payment summary - #72626 (comment)

closing!

@eh2077

$250 approved for @eh2077

Navigation Menu

Repository navigation

[Due for payment 2025-10-30] [$250] Report - Update action message appears when saving a report field without making any change #72626

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

18 remaining items

Payment Summary

BugZero Checklist (@Christinadobrzyn)

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const handleReportFieldChange = (form: FormOnyxValues<typeof ONYXKEYS.FORMS.REPORT_FIELDS_EDIT_FORM>) => {
	const value = form[fieldKey];
	if (isReportFieldTitle) {
	updateReportName(report.reportID, value, report.reportName ?? '');
	goBack();
	} else {
	if (value !== '') {
	updateReportField(
	{...report, reportID: report.reportID},
	{...reportField, value},
	reportField,
	policy as unknown as Policy,
	isASAPSubmitBetaEnabled,
	session?.accountID ?? CONST.DEFAULT_NUMBER_ID,
	session?.email ?? '',
	hasViolations,
	hasOtherViolations,
	);
	}
	goBack();
	}
	};

[Due for payment 2025-10-30] [$250] Report - Update action message appears when saving a report field without making any change #72626

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 14, 2025

Eskalifer1 commented on Oct 14, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Christinadobrzyn commented on Oct 14, 2025

Eskalifer1 commented on Oct 14, 2025

melvin-bot commented on Oct 15, 2025

melvin-bot commented on Oct 15, 2025

eh2077 commented on Oct 15, 2025

18 remaining items

melvin-bot commented on Oct 23, 2025

melvin-bot commented on Oct 23, 2025

Christinadobrzyn commented on Oct 28, 2025

Christinadobrzyn commented on Oct 30, 2025

melvin-bot commented on Oct 30, 2025

Payment Summary

BugZero Checklist (@Christinadobrzyn)

eh2077 commented on Oct 31, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

eh2077 commented on Oct 31, 2025

Christinadobrzyn commented on Oct 31, 2025

garrettmknight commented on Nov 21, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions