Repository navigation
Room - Offline created custom room does not display default avatar #72326
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.2.29-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1235/folder/13176685/41236592/945414506
Email or phone of affected tester (no customers): gocemate+b2154489@gmail.com
Issue reported by: Applause Internal Team
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Other
Action Performed:
- Login with new gmail account
- Go offline
- Create workspace
- Create room
- Click on header
- Look at avatar section on detailed room page
Expected Result:
Default avatar should be displayed
Actual Result:
No avatar is dipslayed
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Oct 10, 2025
Triggered auto assignment to @brianlee-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 10, 2025
Triggered auto assignment to @flodnv (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 10, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 10, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
andriferry commentedon Oct 10, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Room - Offline created custom room does not display default avatar
What is the root cause of that problem?
It's causing the
??(nullish coalescing) operator only replaces the value when the left-hand side isnullorundefined— not when it’s an empty string(""), 0, or false.In this case,
report.avatarUrlends up taking an empty string. Because the avatar is never uploaded.App/src/components/RoomHeaderAvatars.tsx
Line 54 in 941846d
What changes do you think we should make in order to solve the problem?
Just change to conditional (ternary) operator like this
What alternative solutions did you explore? (Optional)
N/A
Result
Screen.Recording.2025-10-10.at.21.31.49.mp4
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
brianlee-expensify commentedon Oct 10, 2025
confirmed that i can reproduce on staging.new.expensify.com
brianlee-expensify commentedon Oct 10, 2025
@flodnv hello! any thoughts on next steps here?
10 remaining items
mountiny commentedon Oct 13, 2025
@samranahm @Beamanator @eh2077 comes from #66883 most likely
Beamanator commentedon Oct 15, 2025
PR was reverted, looks like next PR is WIP
eh2077 commentedon Oct 21, 2025
discussion is ongoing in the parent issue #65210
eh2077 commentedon Oct 28, 2025
commented in the parent issue #65210 (comment)
eh2077 commentedon Nov 14, 2025
@Beamanator I think this can be closed.