Search - Report preview on search shows positive sign when unapproving negative sign expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.28-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #65001
Email or phone of affected tester (no customers): ibellicotest+1903@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

Prerequisite: Account has at least one workspace.
Prerequisite 2: Delayed submissions and approvals enabled.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create a manual expense with negative amount.
4. Submit and approve the expense.
5. Open the expense report.
6. Tap on "More" and unapprove the expense.
7. Tap on the search icon on the top right corner.
8. Note that report preview shows "Unapproved $XX" without negative sign.

Expected Result:

When an expense with negative amount is unapproved, report preview on "Search" should display the expense amount with negative sign.

Actual Result:

After unapproving expene with negative amount, report preview on "Search" shows a "Unapproved $XX" message without negative sign.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

11.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[srikarparsi]

Think this is related to this since it's with negative expenses (but think it more exposes a bug than creates it)

[srikarparsi]

Continuing conversation on the slack thread