Skip to content

Tax values not updated in transaction thread, doesn't sync with concierge & LHN msg #71817

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.22-6
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Web-Expensify/pull/48581
Email or phone of affected tester (no customers): fjdguguru@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 /Chrome
App Component: Money Request

Action Performed:

  1. Naviagte to staging.new.expensify.com
  2. Create a workspace
  3. Enable taxes
  4. Create an expense of X dollars
  5. In the transaction thread, ask to update the tax rate to X
  6. Wait for few seconds (Note: Do not navigate to expense preview)
  7. Observe the tax rate is not updated in transaction thread. (Note. Only LHN message & concierge reply gets displayed correctly)
  8. In the transaction thread, ask to update the tax amount to X (Ex: change the tax amount to $0.05)
  9. Wait for few seconds in transaction thread
  10. Observe the LHN & concierge message get updated to "changed the tax amount to $YY (previously $XX)"
  11. Observe the tax amount field not changed once the LHN & concierge message get updated

Expected Result:

Updated tax amount & rate should be reflected immediately in transaction thread once the LHN & concierge message get updated

Actual Result:

Tax amount & Rate is not updated immediately in transaction thread. Though, LHN & concierge message get updated, tax amount & rate still shows the previous values. User has to navigate back to expense preview & back to transaction thread to view the changes.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

03.10.2025_10.54.47_RECissuerepro.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Oct 3, 2025
  2. melvin-bot commented on Oct 3, 2025

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 3, 2025

    @melvin-bot

    Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 3, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 3, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mitarachim commented on Oct 3, 2025

    @mitarachim
    Author

    Issues found while the QA team was checking the PR.

  7. 17 remaining items

  8. Julesssss commented on Oct 3, 2025

    @Julesssss
    Contributor

    @dangrous looks like you are working on some similar issues, would you like this one too?

  9. dangrous commented on Oct 3, 2025

    @dangrous
    Contributor

    Sure, I can take it! My guess is that we're not sending onyx updates from auth on tax updates, so it shoudl be a pretty quick fix

  10. joekaufmanexpensify commented on Oct 6, 2025

    @joekaufmanexpensify
    Contributor

    Nice, assigned you @dangrous

  11. dangrous commented on Oct 7, 2025

    @dangrous
    Contributor

    Got a fix locally, should have this up for review today!

  12. joekaufmanexpensify commented on Oct 8, 2025

    @joekaufmanexpensify
    Contributor

    PR merged

  13. dangrous commented on Oct 8, 2025

    @dangrous
    Contributor

    This is now on prod, should be resolved if someone has a moment to test!

  14. joekaufmanexpensify commented on Oct 9, 2025

    @joekaufmanexpensify
    Contributor
  15. IuliiaHerets commented on Oct 9, 2025

    @IuliiaHerets

    @joekaufmanexpensify issue is not reproduced anymore on Win 11/Chrome, build v9.2.28-1

    09.10.2025_11.24.10_REC32.mp4
  16. joekaufmanexpensify commented on Oct 9, 2025

    @joekaufmanexpensify
    Contributor

    Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions