Skip to content

Investigate workflow job failing on main: test / test (job 3) #71350

Closed

Description

@github-actions

🚨 Failure Summary 🚨:

  • 📋 Job Name: test / test (job 3)
  • 🔧 Failure in Workflow: Process new code merged to main
  • 🔗 Triggered by PR: PR Link
  • 👤 PR Author: @kstroz
  • 🤝 Merged by: @roryabraham
  • 🐛 Error Message:
    failure: Process completed with exit code 1.
    warning: Cache not found for keys: Linux-node-modules-d404f80f8707543f66c27d64638a51d61ac2d639c73bef19e481a3aa2b3de6ce

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named test / test (job 3).
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

Activity

  1. roryabraham commented on Sep 26, 2025

    @roryabraham
    Contributor

    This doesn't really look like a coincidence to me, and I wouldn't be too too surprised to learn that #71047 caused test failures. I'm going to open a revert and see if tests pass

    Image
  2. kstroz commented on Sep 26, 2025

    @kstroz
    Contributor

    @roryabraham Okay, I think I’m starting to understand the core of the issue. First of all, in the old PR, only the first commit triggered CI, which is why I thought everything was fine. I created a new PR, and now I can reproduce the issue, but only on CI.

    The root cause seems to be the bump in the Babel target of the compiler from 18 to 19, which resulted in longer tests. In most tests, the increase in time was small, but for this particular test, it was significantly larger for some reason. I will continue investigating why changing the compiler target caused the tests to take longer.

    However, I still think this change should remain, as it appears to have been an oversight that it wasn’t updated in the first place.

    Here is the new draft just to confirm my theory:
    #71364

    GH Action with version 18: https://github.com/Expensify/App/actions/runs/18031830367/job/51309790846
    GH Action with version 19: https://github.com/Expensify/App/actions/runs/18032094310/job/51310632930

    Small update:

    • tried updating babel-plugin-react-compiler just to test if it would solve the issue it actually made the test run even longer
    • for now I just made timeout bigger and this solved the issue with this one test but I would still like to know what exactly causes this...
  3. roryabraham commented on Sep 26, 2025

    @roryabraham
    Contributor

    We can continue with follow-up in #71215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions