Skip to content

Add a workflow_dispatch trigger for generateTranslations #71120

Closed

Description

@roryabraham

Problem

The generateTranslations workflow doesn't work for PRs from forks, because workflows triggered by the pull_request event for PRs from forks aren't granted access to repo secrets. Therefore, they don't have access to the OpenAI API token, and can't use it for generating translations.

Solution

We already merged a PR this morning to prevent the workflow from running on PRs from forks. This was necessary to prevent it from failing.

Now, we want a way to be able to trivially generate translations for any PR, including PRs from forks. The solution I'm proposing for now is simple - add a workflow_dispatch trigger and an optional PULL_REQUEST_URL, so that Expensify engineers can manually trigger translations (after reviewing and ensuring that the PR in question does not contain any malicious code intended to leak secrets).

Activity

  1. Julesssss commented on Sep 24, 2025

    @Julesssss
    Contributor

    Making a start on this: #71246

  2. self-assigned this
    on Sep 24, 2025
  3. roryabraham commented on Sep 25, 2025

    @roryabraham
    ContributorAuthor

    awesome, thanks @Julesssss.

  4. Julesssss commented on Sep 25, 2025

    @Julesssss
    Contributor

    One note is that for manual dispatch, we won't have the synchronize param and will check entire PR. Maybe there's a way to improve this but I think this is fine for now.

  5. roryabraham commented on Sep 25, 2025

    @roryabraham
    ContributorAuthor

    I agree that for manual dispatch just checking the whole PR is fine 👍🏼

  6. Julesssss commented on Sep 25, 2025

    @Julesssss
    Contributor
  7. roryabraham commented on Sep 26, 2025

    @roryabraham
    ContributorAuthor

    PR merged, thanks @Julesssss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions