You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add a workflow_dispatch trigger for generateTranslations #71120
The generateTranslations workflow doesn't work for PRs from forks, because workflows triggered by the pull_request event for PRs from forks aren't granted access to repo secrets. Therefore, they don't have access to the OpenAI API token, and can't use it for generating translations.
Solution
We already merged a PR this morning to prevent the workflow from running on PRs from forks. This was necessary to prevent it from failing.
Now, we want a way to be able to trivially generate translations for any PR, including PRs from forks. The solution I'm proposing for now is simple - add a workflow_dispatch trigger and an optional PULL_REQUEST_URL, so that Expensify engineers can manually trigger translations (after reviewing and ensuring that the PR in question does not contain any malicious code intended to leak secrets).
One note is that for manual dispatch, we won't have the synchronize param and will check entire PR. Maybe there's a way to improve this but I think this is fine for now.
Activity
Julesssss commentedon Sep 24, 2025
Making a start on this: #71246
roryabraham commentedon Sep 25, 2025
awesome, thanks @Julesssss.
Julesssss commentedon Sep 25, 2025
One note is that for manual dispatch, we won't have the
synchronizeparam and will check entire PR. Maybe there's a way to improve this but I think this is fine for now.roryabraham commentedon Sep 25, 2025
I agree that for manual dispatch just checking the whole PR is fine 👍🏼
Julesssss commentedon Sep 25, 2025
PR in review
roryabraham commentedon Sep 26, 2025
PR merged, thanks @Julesssss!