[Due for payment 2025-10-21] [$250] Room - Skeleton loading, when invitee leaves the workspace chat with another user

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.16-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-855/folder/13176686/41236628/907085382
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: Mac 15.4.1 Safari, Desktop, iPhone 13 Safari
App Component: Chat Report View

Action Performed:

Precondition: Admin creates a workspace and invites 2 members.

1. Navigate to https://staging.new.expensify.com
2. Login as the admin of the workspace
3. Navigate to the workspace chat with employee A
4. Click on the header of the conversation
5. Click on members
6. Click on the invite button
7. Search for employee B
8. Select employee B and invite them to the workspace chat

Login as Employee B
9. Navigate to the workspace chat with Employee A
10. Click on the header
11. Click Leave

Expected Result:

The user should be navigated to the previous chat after leaving the workspace chat with another user

Actual Result:

Skeleton loading appears, when invitee leaves the workspace chat with another user

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021970193707866673841
• Upwork Job ID: 1970193707866673841
• Last Price Increase: 2025-09-22
• Automatic offers:
• thelullabyy | Contributor | 108945177

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Skeleton loading appears when workspace members leave workspace chats instead of staying in the current chat view.

What is the root cause of that problem?

• The code uses isPolicyEmployee(report?.policyID, policy) which checks if the report belongs to the policy, not if the user is a member of the policy
• For workspace members leaving workspace chats, this incorrectly returns false, making isWorkspaceMemberLeavingWorkspaceRoom false
• This causes navigateToMostRecentReport to be called instead of the early return
• During navigation, report data becomes temporarily inconsistent, triggering skeleton loading via the (!report || shouldWaitForTransactions) condition in ReportScreen

What changes do you think we should make in order to solve the problem?

• Replace isPolicyEmployee with isPolicyMember(policy, session?.email) in ReportDetailsPage isPolicyEmployee(report?.policyID, policy) ... we can also rename the var to be more precise:

    const isPolicyMember = useMemo(() => isPolicyMemberUtil(policy, session?.email), [policy, session?.email]);

• This ensures workspace members get the correct early return behavior when leaving workspace chats, preventing unnecessary navigation and skeleton loading

Result

Screen.Recording.2025-09-21.at.00.29.07.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

we can add a test case that the loading doesnt appear in this case inside the ReportDetailsPageTest

What alternative solutions did you explore? (Optional)

Or we can fix the isPolicyEmployee function in PolicyUtilsto ' to actually check if the current user is a member of the policy
to be something like this:

const isPolicyEmployee = (policy: OnyxEntry<Policy>, userLogin: string | undefined): boolean => {
    return !!policy && !!userLogin && !!policy.employeeList?.[userLogin];
};

in this case we need to add some tests for this change

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Room - Skeleton loading, when invitee leaves the workspace chat with another user

What is the root cause of that problem?

• When user B clicks the "Leave" button (step 11), it triggers the following line:
  

  App/src/pages/ReportDetailsPage.tsx

  Line 310 in d41575d

  leaveRoom(report.reportID, isWorkspaceMemberLeavingWorkspaceRoom);

• At this point, the isWorkspaceMemberLeavingWorkspaceRoom flag is true, which causes an early return here:
  

  App/src/libs/actions/Report.ts

  Lines 3750 to 3752 in d41575d

  	if (isWorkspaceMemberLeavingWorkspaceRoom && !isChatThread) {
  	return;
  	}

  As a result, the navigation logic that should run afterward is skipped:
  

  App/src/libs/actions/Report.ts

  Line 3754 in d41575d

  navigateToMostRecentReport(report);

• Since user B no longer has access to the policy expense chat they just left, the app displays an infinite skeleton loading screen, as observed in the original post.

What changes do you think we should make in order to solve the problem?

• In here:

  App/src/pages/ReportDetailsPage.tsx

  Line 309 in d41575d

  const isWorkspaceMemberLeavingWorkspaceRoom = (report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED || isPolicyExpenseChat) && isPolicyEmployee;

  we can remove || isPolicyExpenseChat part or update it to || (isPolicyExpenseChat && (report?.isOwnPolicyExpenseChat || isPolicyAdmin))

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021970193707866673841

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[brunovjk]

It's on my list, I'll review it ASAP.

[melvin-bot]

@brunovjk Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!