You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When you merge main into your PR branch, and main has changes in en.ts, translations will run on your PR, even though you didn't push any changes originating from your branch or PR.
Solution
The "traditional" solution to this is to find the merge-base between your PR head and the base branch, and then do a diff between your PR head and the merge base. The problem is that takes too long, because there's no efficient way to know how far back in the history you need to search to find the merge base.
This is a common problem, and in other repos we solve it by either:
using fetch-depth: 0, which in E/App takes 3+ minutes
using fetch-depth: 100, which is still kind of slow, but more importantly might arbitrarily not be deep enough.
This ended up being a harder problem to solve than I imagined, but it's a common problem and the solution I came up with should be reusable for other similar needs in the future
Have a draft PR ready for this. It probably works but I think the best way to test will be in App-Test-Fork (or maybe just well-crafted automated tests)
Activity
roryabraham commentedon Sep 20, 2025
This ended up being a harder problem to solve than I imagined, but it's a common problem and the solution I came up with should be reusable for other similar needs in the future
roryabraham commentedon Sep 23, 2025
Have a draft PR ready for this. It probably works but I think the best way to test will be in App-Test-Fork (or maybe just well-crafted automated tests)
roryabraham commentedon Sep 26, 2025
Started creating automated tests. Merging #71246 created non-trivial conflicts