[$250] Bank account - 'Enter signer info' button is not dismissed after entering data

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.8-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #63020
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Workspace Settings

Action Performed:

Prerequisite: Be on account that has global reimbursements beta enabled

1. Create a EUR, CAD, GBP or AUD workspace
2. Go to Workflows tab and press on Add Bank Account
3. Go through the flow up to Step 5
4. In step 5 select that you're not a director and fill in the email of the user you want to invite to add this data
5. Log into account which email you've just provided
6. There should be a chat with a message informing user that he was invited to fill in his data
7. Press on the button 'Enter signer info' and fill in the forms

Expected Result:

'Enter signer info' button is dismissed after entering data

Actual Result:

'Enter signer info' button is not dismissed after entering data

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6933820_1756858537402.not_dis.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021967745497750858924
• Upwork Job ID: 1967745497750858924
• Last Price Increase: 2025-09-23

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Christinadobrzyn]

I don't have a method to connect a non-US bank account for testing, and when I get to the business registration number, I don't have one to add.

Asking QA if we have a test bank account that I can use? https://expensify.slack.com/archives/C9YU7BX5M/p1757624688235649

[m-natarajan]

@Christinadobrzyn We are using only mock data for connecting bank account
Currency : CAD
Swift code: not required
Bank name: CIBC
Bank Region (push row):
Bank City: Oshawa
Bank Address: 365 Bloor street east
Bank Postal: L1H 3M9
iACH: 887654321
Routing code: 12345678
Business phone number: +14157890000
Registration number: 123456780
BN: 999666333

[ShridharGoel]

🚨 Edited by proposal-police: This proposal was edited at 2025-09-17 13:04:52 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In non-USD bank account onboarding, after an invitee enters their signer information via the “Enter signer info” flow, the chat message button in Concierge remains visible in its actionable state instead of reflecting completion.

What is the root cause of that problem?

• The chat message UI decides button state using originalMessage.completed in the report action. However, the client does not optimistically set this flag on successful submission, and the backend response doesn’t reliably provide the updated flag for the invitee’s account in time for the UI to update.

• Additionally, the flow didn’t carry the necessary context (reportID and reportActionID) into the Enter Signer Info screen to allow an optimistic update to the specific action when the save succeeds.

• Chat button renders based on completed, but there was no optimistic update wiring:
  

  App/src/pages/home/report/ReportActionItemMessage.tsx

  Lines 91 to 114 in 3938e13

  	const handleEnterSignerInfoPress = (policyID: string | undefined, bankAccountID: string | undefined, isCompleted: boolean) => {
  	if (!policyID || !bankAccountID) {
  	return;
  	}
  	Navigation.navigate(ROUTES.BANK_ACCOUNT_ENTER_SIGNER_INFO.getRoute(policyID, bankAccountID, isCompleted));
  	};
  	if (isReimbursementDirectionInformationRequiredAction(action)) {
  	const {bankAccountLastFour, currency, policyID, bankAccountID, completed} =
  	getOriginalMessage<typeof CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENT_DIRECTOR_INFORMATION_REQUIRED>(action) ?? {};
  	return (
  	<View style={[styles.chatItemMessage, style]}>
  	<Text>{translate('signerInfoStep.isConnecting', {bankAccountLastFour, currency})}</Text>
  	<Button
  	style={[styles.mt2, styles.alignSelfStart]}
  	success
  	isDisabled={completed}
  	text={translate(completed ? 'signerInfoStep.thisStep' : 'signerInfoStep.enterSignerInfo')}
  	onPress={() => handleEnterSignerInfoPress(policyID, bankAccountID, !!completed)}
  	/>
  	</View>
  	);

• Enter Signer Info submission closes the flow without updating the associated report action:
  

  App/src/pages/ReimbursementAccount/EnterSignerInfo/index.tsx

  Lines 57 to 66 in 3938e13

  	useEffect(() => {
  	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
  	if (enterSignerInfoForm?.errors || enterSignerInfoForm?.isSavingSignerInformation || !enterSignerInfoForm?.isSuccess) {
  	return;
  	}
  	if (enterSignerInfoForm?.isSuccess) {
  	clearEnterSignerInformationFormSave();
  	Navigation.closeRHPFlow();
  	}

What changes do you think we should make in order to solve the problem?

Implement a minimal optimistic completion update:

• Pass reportID and reportActionID when navigating from the chat message to the Enter Signer Info flow.
• On successful save in EnterSignerInfo, merge into Onyx for that report action’s originalMessage to set completed: true. This makes the chat message immediately reflect completion without waiting for a server push.

Updated code snippets

1. Extend route to carry context (policyID, bankAccountID, isCompleted, reportID?, reportActionID?) in src/ROUTES.ts:

BANK_ACCOUNT_ENTER_SIGNER_INFO: {
    route: 'bank-account/enter-signer-info',
    getRoute: (policyID: string | undefined, bankAccountID: string | undefined, isCompleted: boolean, reportID?: string, reportActionID?: string) => {
        if (!policyID) {
            Log.warn('Invalid policyID is used to build the BANK_ACCOUNT_ENTER_SIGNER_INFO route');
        }
        const base = `bank-account/enter-signer-info?policyID=${policyID}&bankAccountID=${bankAccountID}&isCompleted=${isCompleted}` as const;
        const withReportID = reportID ? `${base}&reportID=${reportID}` : base;
        const withActionID = reportActionID ? `${withReportID}&reportActionID=${reportActionID}` : withReportID;
        return withActionID as const;
    },
},

2. Pass reportID and reportActionID from the chat action in src/pages/home/report/ReportActionItemMessage.tsx:

const handleEnterSignerInfoPress = (
    policyID: string | undefined,
    bankAccountID: string | undefined,
    isCompleted: boolean,
    navigateReportID?: string,
    navigateReportActionID?: string,
) => {
    if (!policyID || !bankAccountID) {
        return;
    }
    Navigation.navigate(
        ROUTES.BANK_ACCOUNT_ENTER_SIGNER_INFO.getRoute(policyID, bankAccountID, isCompleted, navigateReportID, navigateReportActionID),
    );
};

// ... inside the render block for the reimbursement director info action
<Button
    style={[styles.mt2, styles.alignSelfStart]}
    success
    isDisabled={completed}
    text={translate(completed ? 'signerInfoStep.thisStep' : 'signerInfoStep.enterSignerInfo')}
    onPress={() => handleEnterSignerInfoPress(policyID, bankAccountID, !!completed, reportID, action.reportActionID)}
/>

3. On successful submission, optimistically set originalMessage.completed = true for that report action in saveCorpayOnboardingDirectorInformation method:

if (reportContext?.reportID && reportContext?.reportActionID) {
        const reportAction = ReportActionsUtils.getReportAction(reportContext.reportID, reportContext.reportActionID);
        if (reportAction) {
            optimisticData.push({
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportContext.reportID}`,
                value: {
                    [reportContext.reportActionID]: {
                        originalMessage: {
                            ...ReportActionsUtils.getOriginalMessage(reportAction),
                            completed: true,
                        },
                    },
                },
            });
        }
    }

Note: Backend changes might also be needed so that the updated value of completed field becomes available.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

New test can be added to verify that after a successful save in Enter Signer Info, the corresponding report action’s originalMessage.completed is set to true in Onyx.

[Christinadobrzyn]

I'm still not able to test with the gloabl bank account for some reason - #70251 (comment)

Going to set this to External since we have a proposal to see if we can get this to work otherwise.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021967745497750858924