[Due for payment 2025-09-30] [$250] Hide 'Switch to Expensify Classic' button for users with isLockedToNewDot NVP

[Julesssss]

Problem

Workspace admins are finding that their members are switching back to Expensify Classic against the admins wishes. The button is accessable by all users under Settings > Troubleshooting.

Users should still be able to switch from Expensify Classic to New Expensify.

Solution

We have implemented functionality on the backend for locking users into the New Expensify app experience. Now we need the client to actually hide the button based on the key.

If users tryNewDot NVP contains the key classicRedirect.isLockedToNewDot that is set to true, the 'Switch to Expensify Classic' button should not be displayed under Troubleshooting. The 'Try New Expensify' button in Expensify classic will not be hidden.

{
  "classicRedirect": {
    "dismissed": true,
    "isLockedToNewDot": false, <-- new key
  }
}

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021967674024490490605
• Upwork Job ID: 1967674024490490605
• Last Price Increase: 2025-09-15

Issue Owner

Current Issue Owner: @DylanDylann

[Eskalifer1]

I will leave proposal in case this is open for contributors:

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hide 'Switch to Expensify Classic' button for users with isLockedToNewDot NVP

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?

Here is where we add this element to the list:

App/src/pages/settings/Troubleshoot/TroubleshootPage.tsx

Lines 73 to 103 in 87f838a

	const baseMenuItems: BaseMenuItem[] = [
	{
	translationKey: 'exitSurvey.goToExpensifyClassic',
	icon: Expensicons.ExpensifyLogoNew,
	...(CONFIG.IS_HYBRID_APP
	? {
	action: () => closeReactNativeApp({shouldSetNVP: true}),
	}
	: {
	action() {
	resetExitSurveyForm(() => {
	if (shouldOpenSurveyReasonPage) {
	Navigation.navigate(ROUTES.SETTINGS_EXIT_SURVEY_REASON.route);
	return;
	}
	Navigation.navigate(ROUTES.SETTINGS_EXIT_SURVEY_CONFIRM.route);
	});
	},
	}),
	},
	{
	translationKey: 'initialSettingsPage.troubleshoot.clearCacheAndRestart',
	icon: Expensicons.RotateLeft,
	action: () => setIsConfirmationModalVisible(true),
	},
	{
	translationKey: 'initialSettingsPage.troubleshoot.exportOnyxState',
	icon: Expensicons.Download,
	action: exportOnyxState,
	},
	];

We need to display it dynamically depending on tryNewDot?.classicRedirect?.isLockedToNewDot. This component already has tryNewDot, and we also need to update the types.

And update all other places that uses Switch to Expensify classic

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The "Switch to Expensify Classic" button should not be visible to users who have the isLockedToNewDot NVP set to true.

What is the root cause of that problem?

• NA

What changes do you think we should make in order to solve the problem?

We need to implement the following changes:

1. Hide the "Switch to Expensify Classic" button when isLockedToNewDot is true:

   • On the Troubleshoot page:

     • Hide the button here.

   • Optional: In other locations where the button or redirection logic exists, update conditions to account for isLockedToNewDot. For example:

     • Update shouldRedirectToExpensifyClassic here to include the isLockedToNewDot check.
     • Update shouldRedirectToExpensifyClassic here similarly.

2. Prevent access to screens related to the "Switch to Expensify Classic" flow:

   • In the following pages, show the "Not Found" page when isLockedToNewDot is true:
     • ExitSurveyReasonPage
     • ExitSurveyResponsePage
     • ExitSurveyConfirmPage

We can do it by wrapping the page by <FullPageNotFoundView shouldShow={isLockedToNewDot}>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• N/A

What alternative solutions did you explore? (Optional)

[melvin-bot]

@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Julesssss]

Backend changes in progress

[Julesssss]

Optional: In other locations where the button or redirection logic exists, update conditions to account for isLockedToNewDot.

Thanks for sharing @thelullabyy, but we'll not modify the redirection logic itself, as that is controlled with a different key. As for the exit survey pages we'll continue to allow redirection in those unique cases (for new workspace admins, ect).