[HOLD for payment 2022-05-23] [$250] Auto-handle phone number format by stripping any parentheses/dashes on submit - Reported by @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Navigate to Settings > Workspace > Connect bank account
3. Proceed with VBA flow to Company information page
4. Enter phone number in different formats (e.g with/without parentheses/dashes)

Expected Result:

User should be able to enter phone number in any format

Actual Result:

The phone number placeholder suggests that the input should be in this format (xxx)xxx-xxxx however, it will throw an error if we do that. So, either the placeholder should be updated or the input should be handled accordingly.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.24-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2021-12-24.at.7.46.08.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640355502103900

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[thesahindia]

Proposal

using the below function, we can remove the special characters from the phone number and avoid the error that we are getting right now

    stripSpecialCharacters(number) {
        return number.replace(CONST.REGEX.NUMBERS_WITHOUT_SPECIAL_CHARS, '');
    }

Inside https://github.com/Expensify/App/blob/main/src/pages/ReimbursementAccount/CompanyStep.js
the submit function will look like this -

submit() {
     if (!this.validate()) {
         BankAccounts.showBankAccountErrorModal();
         return;
     }

     const incorporationDate = moment(this.state.incorporationDate).format(CONST.DATE.MOMENT_FORMAT_STRING);
     const companyPhone = this.stripSpecialCharacters(this.state.companyPhone);
     BankAccounts.setupWithdrawalAccount({...this.state, incorporationDate, companyPhone});
 }

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)