[Payment due 9/12] Invoice - Invoices don't have archive on subtitle after delete workspace

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.0-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-513/folder/13176671/41237466/864760335
Email or phone of affected tester (no customers): utester29+1_admin2@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome
App Component: Other

Action Performed:

1. Login to https://staging.new.expensify.com/
2. Create a workspace and send an invoice within that workspace
3. Delete the workspace
4. Navigate to "Reports"
5. Click on the dropdown "Type:Expenses"
6. Click on the Invoice
7. Click on the "Apply" button
8. Click on the "Invoice report" > View
9. Click on the invoice preview

Expected Result:

Verify that the (archived) label appears in the subtitle of the invoice

Actual Result:

The archived label is not shown as a subtitle in the Invoice

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice report subtitle (From ...) doesn't show (archived) text.

What is the root cause of that problem?

This happens after #68509. (archived) will be added if the parent report is archived, but after the PR, we use the archived state of the current report instead of the parent.

App/src/libs/ReportUtils.ts

Lines 5520 to 5525 in 19befda

	if (isInvoiceReport(report) || isInvoiceRoom(parentReport)) {
	let reportName = `${getPolicyName({report: parentReport})} & ${getInvoicePayerName(parentReport)}`;
	if (isArchivedNonExpenseReport(parentReport, isReportArchived)) {
	reportName += ` (${translateLocal('common.archived')})`;
	}

App/src/components/AvatarWithDisplayName.tsx

Lines 172 to 174 in 19befda

	const isReportArchived = useReportIsArchived(report?.reportID);
	const subtitle = getChatRoomSubtitle(report, true, isReportArchived);
	const parentNavigationSubtitleData = getParentNavigationSubtitle(report, isReportArchived);

What changes do you think we should make in order to solve the problem?

We should pass the parent report archived state.

const isParentReportArchived = useReportIsArchived(report?.parentReportID);
const parentNavigationSubtitleData = getParentNavigationSubtitle(report, isParentReportArchived);

We need to apply it to all getParentNavigationSubtitle usages.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[DylanDylann]

@nkdengineer It is a regression from our PR. Could you please raise a quick PR to fix it?

[nkdengineer]

@DylanDylann I'll create a follow up PR soon

[Christinadobrzyn]

adding @DylanDylann and @nkdengineer to this GH for tracking. Thanks for working on the PR!

[Christinadobrzyn]

PR merged to production - #69424

Adding payment date - do we need a regression test for this?