[Due for payment 2025-09-30] [$250] Invoice- Inconsistent avatar for message thread in invoice room & invoice report after payment

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.99-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://test-management.browserstack.com/projects/2219752/test-runs/TR-441/folder/13176671/41237469/861420390
Email or phone of affected tester (no customers): sdoisnjsdjnoisojid11@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Invoice is enabled.

1. Go to staging.new.expensify.com

2. [User A] Send an invoice to User B.

3. [User A] Send a message in the invoice room.

4. [User A] Right click on the message > Reply in thread.
   → BUG 1: Thread header shows user avatar and then changes to duplicate workspace avatars.

5. [User B] Open the invoice report.

6. [User B] Click Pay > Pay as an individual > Mark as paid.
   → BUG 2: Subscript avatar on the invoice report header disappears after paying invoice as an individual.

7. [User A] Send another invoice to User B.

8. [User B] Open the invoice report.

9. [User B] Click Pay > Pay as a business > Mark as paid.
   → BUG 3: After paying the invoice as a business, the workspace avatars are initially of the same size, then changes to one big avatar and one small avatar.

Expected Result:

BUG 1: Thread header for the message sent in the invoice room will show the message sender's avatar.
BUG 2: Subscript avatar on the invoice report header will not disappear after paying invoice as an individual.
BUG 3: After paying the invoice as a business, the workspace avatars should not change from one to another.

Actual Result:

BUG 1: Thread header shows user avatar and then changes to duplicate workspace avatars.
BUG 2: Subscript avatar on the invoice report header disappears after paying invoice as an individual.
BUG 3: After paying the invoice as a business, the workspace avatars are initially of the same size, then changes to one big avatar and one small avatar.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021965929717053858968
• Upwork Job ID: 1965929717053858968
• Last Price Increase: 2025-09-11

Issue Owner

Current Issue Owner: @cead22

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent invoice avatar.

What is the root cause of that problem?

For bug 2 and 3, it's a BE bug. When we pay the invoice, the report parentReportActionID value becomes an integer and wrong. From the example below, it becomes 8434870516455393000 instead of 8434870516455392954

This cause isAReportPreviewAction to be false even though it should be true because the parent action is a report preview.

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Line 69 in 6bd3340

const isAReportPreviewAction = action?.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW;

For the bug 2, this causes the avatar type to be single (default) instead of subscript.
For the bug 3, this causes the avatar type to be subscript instead of multiple.

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Lines 300 to 307 in 6bd3340

	if (isNestedInInvoiceReport && !!avatars.at(1)?.id) {
	// If we have B2B Invoice between two workspaces we only should show subscript if it is not a report preview
	if (avatars.every(({type}) => type === CONST.ICON_TYPE_WORKSPACE)) {
	avatarType = isAReportPreviewAction ? CONST.REPORT_ACTION_AVATARS.TYPE.MULTIPLE : CONST.REPORT_ACTION_AVATARS.TYPE.SUBSCRIPT;
	// But if it is a report preview between workspace and another user it should never be displayed as a multiple avatar
	} else if (isWorkspaceWithUserAvatar && isAReportPreviewAction) {
	avatarType = CONST.REPORT_ACTION_AVATARS.TYPE.SUBSCRIPT;
	}

For bug 1, when we create a thread in an invoice report, isNestedInInvoiceReport is also true, so it follows the invoice report avatar logic which we don't want for a thread.

What changes do you think we should make in order to solve the problem?

Bug 2 and 3 should be fixed on the BE.

For bug 1, we can update isNestedInInvoiceReport condition to exclude chat thread.

const isNestedInInvoiceReport = !!invoiceReport && !isChatThread(report);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test useReportActionAvatars hook and make sure it returns single type avatar with the correct source when it's a thread inside invoice report.

[melvin-bot]

@lydiabarclay Huh... This is 4 days overdue. Who can take care of this?

[lydiabarclay]

Reviewing asap

[lydiabarclay]

@Expensify/product can you confirm the expected behavior here?

[lydiabarclay]

Bump!

[melvin-bot]

@lydiabarclay Whoops! This issue is 2 days overdue. Let's get this updated quick!