Skip to content

[Due for payment 2025-10-17] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_ACTIONS in src/libs/markAllPolicyReportsAsRead.ts #69026

Closed
Closed
[Due for payment 2025-10-17] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_ACTIONS in src/libs/markAllPolicyReportsAsRead.ts#69026
Assignees
danieldoglasparasharrajatVictoriaExpensifyshubham1206agra
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Description

@tgolen
tgolen
opened on Aug 22, 2025

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code

Activity

  1. tgolen
    assigned
    danieldoglas
    on Aug 22, 2025
  2. tgolen
    added
    Engineering
    WeeklyKSv2
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2025

  3. tgolen commented on Aug 22, 2025

    @tgolen
    tgolen
    on Aug 22, 2025
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. tgolen
    added a parent issue on Aug 22, 2025
  5. melvin-bot
    assigned
    CortneyOfstad
    on Aug 22, 2025

  6. melvin-bot commented on Aug 22, 2025

    @melvin-bot
    melvin-botBot
    on Aug 22, 2025 – with Melvin Bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  7. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Aug 22, 2025
  8. tgolen
    assigned
    allgandalf
    and
    shubham1206agra
    on Aug 22, 2025
  9. danieldoglas
    added
    MonthlyKSv2
    and removed
    DailyKSv2
    on Aug 22, 2025

  10. 12 remaining items

  11. melvin-bot commented on Oct 17, 2025

    @melvin-bot
    melvin-botBot
    on Oct 17, 2025 – with Melvin Bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  12. melvin-bot
    assigned
    VictoriaExpensify
    on Oct 17, 2025
  13. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 17, 2025
  14. danieldoglas
    changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT_ACTIONS` in `src/libs/markAllPolicyReportsAsRead.ts`[/-] [+][Due for payment 2025-10-17] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT_ACTIONS` in `src/libs/markAllPolicyReportsAsRead.ts`[/+] on Oct 17, 2025
  15. danieldoglas
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Oct 17, 2025

  16. danieldoglas commented on Oct 17, 2025

    @danieldoglas
    danieldoglas
    on Oct 17, 2025
    Contributor

    @VictoriaExpensify this one is ready for payment. Should be $125

  17. shubham1206agra commented on Oct 17, 2025

    @shubham1206agra
    shubham1206agra
    on Oct 17, 2025
    Contributor

    @danieldoglas Can we combine payment with #69025 and make this $250 here? Also, we have tested the PR too.

  18. danieldoglas commented on Oct 17, 2025

    @danieldoglas
    danieldoglas
    on Oct 17, 2025
    Contributor

    Yeah, we can do that. @VictoriaExpensify it should be $250. I'll close the other issue.

  19. VictoriaExpensify commented on Oct 20, 2025

    @VictoriaExpensify
    VictoriaExpensify
    on Oct 20, 2025
    Contributor

    Payment summary:
    C+: @shubham1206agra owed $250 via NewDot
    C+: @parasharrajat owed $250 via NewDot

    Thanks all!

  20. VictoriaExpensify
    closed this as completedon Oct 20, 2025

  21. JmillsExpensify commented on Oct 21, 2025

    @JmillsExpensify
    JmillsExpensify
    on Oct 21, 2025
    Contributor

    $250 approved for @shubham1206agra

  22. parasharrajat commented on Nov 9, 2025

    @parasharrajat
    parasharrajat
    on Nov 9, 2025
    Member

    Payment requested as per #69026 (comment)

  23. trjExpensify commented on Nov 17, 2025

    @trjExpensify
    trjExpensify
    on Nov 17, 2025
    Contributor

    approved $250 for @parasharrajat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions