[Due for payment 2025-09-12] [$250] Track - When deleting moved expenses, "deleted expense" box with comments is shown & app navigates to concierge

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.96-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-327/folder/13176877/41237366/846109672
Email or phone of affected tester (no customers): Slottwo1 2@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Money Requests

Action Performed:

1. Launch app
2. Open workpace chat
3. Create 2 expenses
4. In expense reports, tap more - delete
5. Go to self dm
6. Open any one expense
7. Tap header - delete

Expected Result:

After deleting moved track expense, must be navigated to self dm page.

Actual Result:

After deleting moved track expense, deleted expense box with comments shown briefly and directed to concierge

Note: In expensifail account, user directed to self dm page after deleting moved expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6920671_1755584937701.Screenrecorder-2025-08-19-11-43-34-806.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021958244076152104218
• Upwork Job ID: 1958244076152104218
• Last Price Increase: 2025-08-20
• Automatic offers:
• thelullabyy | Contributor | 108756996

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nabi-ebrahimi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track - When deleting moved expenses, "deleted expense" box with comments is shown & app navigates to concierge

What is the root cause of that problem?

After deleting an expense, this code snippet runs to navigate to the next route.

App/src/pages/ReportDetailsPage.tsx

Lines 823 to 826 in d1b5bdd

	const isTrackExpense = isTrackExpenseAction(requestParentReportAction);
	if (isTrackExpense) {
	urlToNavigateBack = getNavigationUrlAfterTrackExpenseDelete(moneyRequestReport?.reportID, iouTransactionID, requestParentReportAction, isSingleTransactionView);
	} else {

The urlToNavigateBack is undefined, so this block runs.

App/src/pages/ReportDetailsPage.tsx

Lines 831 to 833 in d1b5bdd

	if (!urlToNavigateBack) {
	Navigation.dismissModal();
	} else {

So it dismisses the details modal and the user stays on the deleted expense report.

What changes do you think we should make in order to solve the problem?

Here, after deleting the expense. We can call goBack, to not to stay on the deleted report expense if deleteTrackExpense returned undefined.

App/src/pages/ReportDetailsPage.tsx

Lines 777 to 781 in d1b5bdd

	const isTrackExpense = isTrackExpenseAction(requestParentReportAction);
	if (isTrackExpense) {
	deleteTrackExpense(moneyRequestReport?.reportID, iouTransactionID, requestParentReportAction, duplicateTransactions, duplicateTransactionViolations, isSingleTransactionView);
	} else {

    const urlToNavigate = deleteTrackExpense(
                moneyRequestReport?.reportID,
                iouTransactionID,
                requestParentReportAction,
                duplicateTransactions,
                duplicateTransactionViolations,
                isSingleTransactionView,
            );

            if (!urlToNavigate) {
                Navigation.goBack();
            }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

We can call goBack immediately after dismissing the modal.

        if (!urlToNavigateBack) {
                   Navigation.dismissModal();
            Navigation.isNavigationReady().then(() => {
                Navigation.goBack();
            });

[nabi-ebrahimi]

My proposal demo.

Screen.Recording.1404-05-28.at.2.59.54.PM.mov

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting a moved Track expense, the deleted expense box with comments briefly appears before the user is redirected to Concierge.

What is the root cause of that problem?

• When deleting a Track expense, navigation is handled here:
  

  App/src/pages/ReportDetailsPage.tsx

  Lines 824 to 825 in 11ef858

  	if (isTrackExpense) {
  	urlToNavigateBack = getNavigationUrlAfterTrackExpenseDelete(moneyRequestReport?.reportID, iouTransactionID, requestParentReportAction, isSingleTransactionView);

  
  In this flow, getNavigationUrlAfterTrackExpenseDelete returns undefined, which only triggers dismissModal:
  

  App/src/pages/ReportDetailsPage.tsx

  Line 832 in 11ef858

  Navigation.dismissModal();

• As a result, the report details page closes and the user lands back on the transaction thread report that is being deleted. Once that report disappears, the app falls back to navigating to Concierge:
  

  App/src/pages/home/ReportScreen.tsx

  Line 681 in 5b6683b

  navigateToConciergeChat();

• The root cause is that getNavigationUrlAfterTrackExpenseDelete returns undefined in this scenario:
  

  App/src/libs/actions/IOU.ts

  Lines 7929 to 7937 in 5b6683b

  	const shouldDeleteTransactionThread = transactionThreadID ? (reportAction?.childVisibleActionCount ?? 0) === 0 : false;
  	// Only navigate if in single transaction view and the thread will be deleted
  	if (isSingleTransactionView && shouldDeleteTransactionThread && chatReport?.reportID) {
  	// Pop the deleted report screen before navigating. This prevents navigating to the Concierge chat due to the missing report.
  	return ROUTES.REPORT_WITH_ID.getRoute(chatReport.reportID);
  	}
  	return undefined;

  
  Here, shouldDeleteTransactionThread is false because reportAction?.childVisibleActionCount > 0, so no navigation URL is provided.

What changes do you think we should make in order to solve the problem?

• We should remove the shouldDeleteTransactionThread condition in this case:
  

  App/src/libs/actions/IOU.ts

  Line 7932 in 5b6683b

  if (isSingleTransactionView && shouldDeleteTransactionThread && chatReport?.reportID) {

  
  For self DM reports, deleting any Track expense should always remove the corresponding transaction thread, regardless of whether it has visible messages.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• N/A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021958244076152104218

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)