[Due for payment 2025-10-07] [$250] Android - Reports -When deleting expense while offline, selection mode is applied on preview

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.96-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-327/folder/13176670/41237092/846109493
Email or phone of affected tester (no customers): ibellicotest+1616@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Search

Action Performed:

Prerequisite: Account has at least one workspace available.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create two manual expenses.
4. Navigate to Reports.
5. If you are not on "Submit" section, navigate to it.
6. Turn off internet connection.
7. Open the report of the just created expenses.
8. Long tap and select the expense displayed on top.
9. Delete the expense.
10. Use the device´s back button to return to "Reports"
11. Note that when you land on "Reports", selection mode is applied on expenses preview.

Expected Result:

When deleting an expense from a report while offline, selection mode shouldn´t be applied on the report preview when returning.

Actual Result:

When opening a report and deleting an expense while offline on "Submit" section, selection mode is applied on the report preview when using device´s back button to return.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6920616_1755574436892.Selection.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021961209396410763283
• Upwork Job ID: 1961209396410763283
• Last Price Increase: 2025-08-28

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When opening a report and deleting an expense while offline on "Submit" section, selection mode is applied on the report preview when using device´s back button to return.

What is the root cause of that problem?

In offline, the delete transaction is marked as pending delete, then after deleting the transaction offline, the selection mode is not turned off. We can see that the header of the report is still in the selection mode.

App/src/components/MoneyReportHeader.tsx

Lines 1052 to 1056 in b7b6678

	if (transactions.length <= 1) {
	turnOffMobileSelectionMode();
	}
	return (

That's why the selection mode is enabled when we go back to Reports

What changes do you think we should make in order to solve the problem?

We need to check the visible transaction length instead

const visibleTransactions = transactions.filter((t) => t.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
if (visibleTransactions.length <= 1) {
    turnOffMobileSelectionMode();
}

App/src/components/MoneyReportHeader.tsx

Lines 1052 to 1056 in b7b6678

	if (transactions.length <= 1) {
	turnOffMobileSelectionMode();
	}
	return (

And we also need to turn off the selection mode when the MoneyReportHeader is unmounted to prevent the same bug.

useEffect(() => {
    return () => {
        turnOffMobileSelectionMode();
    }
}, []);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[trjExpensify]

Asking if this will be fixed by #66028 (comment)

[trjExpensify]

Held on #67216

[melvin-bot]

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

Deployed to staging. This can be retested.