[Due for payment 2025-09-09] [$250] Workspace - Hovering over the new user avatar does not display email address

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.96-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-324/folder/13177080/41237935/846107483?p=2
Email or phone of affected tester (no customers): gocemate+b2154117@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Create workspace
2. Go to members> Invite
3. Enter email address for a new participant that doesn't have expensify account yet> Select use> Next
4. On confirm details page hover over user's avatar

Expected Result:

Hovering over the avatars should display the participant emails

Actual Result:

Hovering over the new user avatar does not display email address

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6920300_1755540356268.Recording__5968.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021958224546053915026
• Upwork Job ID: 1958224546053915026
• Last Price Increase: 2025-08-20
• Automatic offers:
• nkdengineer | Contributor | 108535499

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Hovering over the new user avatar does not display email address

What is the root cause of that problem?

Here is where we use the avatar:

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 195 to 202 in 5aa1619

	<ReportActionAvatars
	size={CONST.AVATAR_SIZE.LARGE}
	accountIDs={Object.values(invitedEmailsToAccountIDsDraft ?? {})}
	horizontalStacking={{
	displayInRows: true,
	}}
	secondaryAvatarContainerStyle={styles.secondAvatarInline}
	/>

But we don't add fallbackDisplayName, so we try to get information from personalDetails, but since there is no such information there, we don't display anything

What changes do you think we should make in order to solve the problem?

We need to pass this prop:

fallbackDisplayName={Object.keys(invitedEmailsToAccountIDsDraft ?? {}).join(‘,’)}

And in the ReportActionAvatarMultipleHorizontal component, add comma separation and display depending on the index:

App/src/components/ReportActionAvatars/ReportActionAvatar.tsx

Lines 383 to 392 in 5aa1619

	<UserDetailsTooltip
	key={`stackedAvatars-${icon.id}`}
	accountID={Number(icon.id)}
	icon={icon}
	fallbackUserDetails={{
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	displayName: fallbackDisplayName || icon.name,
	}}
	shouldRender={shouldShowTooltip}
	>

 const fallbackNames = useMemo(() => fallbackDisplayName?.split(‘,’).map((s) => s.trim()) ?? [], [fallbackDisplayName]);

<UserDetailsTooltip
                    key={`stackedAvatars-${icon.id}`}
                    accountID={Number(icon.id)}
                    icon={icon}
                    fallbackUserDetails={{
                        // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
                        displayName: fallbackNames[index] || icon.name,
                    }}
                    shouldRender={shouldShowTooltip}
                >

We can change the display of icon.name first, and then fallbackNames[index]

PS: This can be done dynamically by passing props so that if the value of this prop is true, the string is split by commas, and if false, fallbackName is displayed the same for all elements

If necessary, you can rewrite the fallbackName logic from a string to an array, but in my proposal I suggested a solution that will require less code rewriting

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hovering over the new user avatar does not display email address

What is the root cause of that problem?

When we invite the new member, Their personal details will not be saved in the onyx key PERSONAL_DETAILS_LIST but in the onyx key WORKSPACE_INVITE_MEMBERS_DRAFT

It leads to us returning the name as '' here

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Lines 102 to 107 in 5aa1619

	const avatarsForAccountIDs: IconType[] = accountIDsToMap.map((id) => ({
	id,
	type: CONST.ICON_TYPE_AVATAR,
	source: personalDetails?.[id]?.avatar ?? FallbackAvatar,
	name: personalDetails?.[id]?.[shouldUseActorAccountID ? 'displayName' : 'login'] ?? '',
	}));

What changes do you think we should make in order to solve the problem?

1. We should pass policyIDas route.params.policyID here

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 195 to 202 in 5aa1619

	<ReportActionAvatars
	size={CONST.AVATAR_SIZE.LARGE}
	accountIDs={Object.values(invitedEmailsToAccountIDsDraft ?? {})}
	horizontalStacking={{
	displayInRows: true,
	}}
	secondaryAvatarContainerStyle={styles.secondAvatarInline}
	/>

2. We should get the invitedEmailsToAccountIDs in useReportActionAvatars by using props or we can get it directly via WORKSPACE_INVITE_MEMBERS_DRAFT onyx key. Then update the fallback

   // We can create a props `invitedEmailsToAccountIDs` and pass it from `WorkspaceInviteMessagePage` component

    const avatarsForAccountIDs: IconType[] = accountIDsToMap.map((id) => {
        const invitedEmail = invitedEmailsToAccountIDs ? Object.keys(invitedEmailsToAccountIDs).find((email) => invitedEmailsToAccountIDs[email] === id) : undefined;
        return {
            id,
            type: CONST.ICON_TYPE_AVATAR,
            source: personalDetails?.[id]?.avatar ?? FallbackAvatar,
            name: personalDetails?.[id]?.[shouldUseActorAccountID ? 'displayName' : 'login'] ?? invitedEmail ?? '',
        }
    });

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Lines 102 to 107 in 5aa1619

	const avatarsForAccountIDs: IconType[] = accountIDsToMap.map((id) => ({
	id,
	type: CONST.ICON_TYPE_AVATAR,
	source: personalDetails?.[id]?.avatar ?? FallbackAvatar,
	name: personalDetails?.[id]?.[shouldUseActorAccountID ? 'displayName' : 'login'] ?? '',
	}));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021958224546053915026

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[eh2077]

Thank you for your proposals!

I think the right practice is to display the missing email using draft data from key WORKSPACE_INVITE_MEMBERS_DRAFT. I think we should go with @nkdengineer 's proposal, as their solution is the cleanest.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.