[$500] Workspace - Pinned Room Shows "No Activity" After Workspace Is Deleted

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.94-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13177019/test-cases/41237784
Email or phone of affected tester (no customers): na
Issue reported by: Applause Internal Team
Device used: Win 11/Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Precondition:
user A : Owner - main device
user B: admin - secondary device

1. [user A] Open the link www.staging.expensify.com
2. [User A] logged in
3. [User A] create Collect workspace then add another 2 members in the workspace (total there are 3 member in the workspace)
4. [User A] Assigned 1 member to admin role [User B]
5. Logged in with User B
6. [User B] navigate to Admin room, enter any chat
7. [User B]] Navigate to Announce room, enter any chat
8. [user A] disable internet
9. [user A] Navigate to Workspace, tap on 3 dot >> Select "Delete"
10. [User B] navigate to Announce room>> Pin the Announce room >> send any random text to announce room
    11.[User B] navigate to admin room >> send any random text to admin room
11. [User A] then enable internet , observe the workspace is deleted successful
    13 [User B] >> navigate to Inbox, there is place holder "No activity" displayed

Expected Result:

After the workspace is deleted by the owner (User A), any pinned rooms (e.g., Announce or Admin) should Be removed from the Left-Hand Navigation (LHN).

Actual Result:

When User B pins either the Announce room or the Admin room, and the workspace is deleted by User A, the pinned room remains visible in the Left-Hand Navigation (LHN) but incorrectly displays a "No activity" placeholder. This placeholder persists until the page is refreshed, after which it disappears.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021960884522597990765
• Upwork Job ID: 1960884522597990765
• Last Price Increase: 2026-01-08
• Automatic offers:
• mkzie2 | Contributor | 108975921

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pinned Room Shows "No Activity" After Workspace Is Deleted

What is the root cause of that problem?

From the admin side, we received the pusher that updates the admin room to null and then updates the data isPinned: false. So the admin report object is still not empty in the Onyx

App/src/hooks/useSidebarOrderedReports.tsx

Lines 87 to 89 in 538e440

	} else if (reportUpdates) {
	reportsToUpdate = Object.keys(reportUpdates ?? {});
	} else if (reportNameValuePairsUpdates) {

The updateReportsToDisplayInLHN only filters out the report if it's undefined then a invalid report is still shown in LHN

App/src/libs/SidebarUtils.ts

Lines 315 to 319 in 538e440

	const report = reports?.[reportID];
	if (!report) {
	return;
	}

What changes do you think we should make in order to solve the problem?

We should also filter out the report without reportID here. We can also do it here

if (!report || !report.reportID) {
    return;
}

App/src/libs/SidebarUtils.ts

Lines 315 to 319 in 538e440

	const report = reports?.[reportID];
	if (!report) {
	return;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add unit test for updateReportsToDisplayInLHN function and verify it filters out the not found report.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

Working on reproing.

[strepanier03]

The repro steps are a bit odd to me.

1. The link is to go to Expensify Classic, is this really accurate?
2. [User B]] Navigate to Announce room, enter any chat - Does "enter any chat" mean send a message, go to a different chat room?

[strepanier03]

I rewatched the video and made some assumptions and tested this.

After coming back online, the pinned rooms are not visible in the Inbox of account B, they were removed when I navigated to the Inbox.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989