[due for payment 2025-09-02] “View” Button Displays Instead of “Submit” After Undo Close While Offline

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.93-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #66140
Email or phone of affected tester (no customers): applausetester+dp300@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac / Sequoia 15.6 / Desktop app
App Component: Other

Action Performed:

1. User A – Create a workspace, disable Delayed Submit, Add approvals, Make or track payments.
2. User A – Invite User B to the workspace.
3. User B – Create an expense (expense moves to Closed state).
4. User A – Go offline.
5. User A – Undo Close for the expense.
6. User A – Open the report preview.

Expected Result:

The grey Submit button is displayed.

Actual Result:

View button is displayed instead of Submit.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6915091_1755019666408.10_25_AM_2025-08-12.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

View button is displayed instead of Submit.

What is the root cause of that problem?

We only pass the report data when checking hasBeenRetracted because we don't want to subscribe the report action of the iou report in the report preview

App/src/libs/ReportPreviewActionUtils.ts

Line 50 in d80a995

const hasBeenRetracted = hasReportBeenReopenedUtils(report) || hasReportBeenRetractedUtils(report);

And because we don't update hasReportBeenReopened to true when the report is undo closed, this function returns false

App/src/libs/actions/IOU.ts

Line 9816 in f5698b9

const optimisticIOUReportData: OnyxUpdate = {

What changes do you think we should make in order to solve the problem?

We should update hasReportBeenReopened to true in the optimistic data and revert it in the failure data.

hasReportBeenReopened: true,

App/src/libs/actions/IOU.ts

Line 9816 in f5698b9

const optimisticIOUReportData: OnyxUpdate = {

We should do the same for undo submit

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Write reopenReport unit test and verify hasReportBeenReopened is true

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[joekaufmanexpensify]

This works right now with retract, it's just an issue with reopen. Discussing here as i think we should have maybe handled this in #66140

[joekaufmanexpensify]

@rushatgabhane is investigating this, as seems maybe related to his PR above

[nkdengineer]

@joekaufmanexpensify This issue started happening after this PR

[joekaufmanexpensify]

@rushatgabhane is fixing this because it's related to a project he's been working on, PR: #68552

[joekaufmanexpensify]

PR in review