[Due for payment 2025-09-12] [$250] Invoice - created invoice report is blurred when offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.91-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: Account having sent invoice to any user in other day, not today

1. Open app
2. Go to invoice room
3. Tap Send Invoice
4. Create and send invoice
5. Turn off internet

Expected Result:

Turn off internet, the new created invoice should display normal

Actual Result:

Turn off internet, the new created invoice is blurred but invoices created in previous day not blurred

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

0-02-01-06ac4422253df81ec4648aeb635339dbb1ab797abc3d9a0336ededaad1d89259_b3c8db3d4b6bb40b.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021955574160627954149
• Upwork Job ID: 1955574160627954149
• Last Price Increase: 2025-08-20
• Automatic offers:
• thelullabyy | Contributor | 108495804

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Turn off internet, the new created invoice is blurred but invoices created in previous day not blurred

What is the root cause of that problem?

In here we don't have logic to clean-up the isOptimisticAction data in successData so the pendingAction is add in:

App/src/pages/home/report/PureReportActionItem.tsx

Lines 1517 to 1519 in abf9f6d

	pendingAction={
	draftMessage !== undefined ? undefined : (action.pendingAction ?? (action.isOptimisticAction ? CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD : undefined))
	}

What changes do you think we should make in order to solve the problem?

We should add logic to clean-up the isOptimisticAction field in successData (and failedData if needed). We can do it in:

App/src/libs/actions/IOU.ts

Lines 2230 to 2232 in abf9f6d

	[chat.reportPreviewAction.reportActionID]: {
	pendingAction: null,
	},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add test for buildOnyxDataForInvoice

What alternative solutions did you explore? (Optional)

[dylanexpensify]

reviewing today!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021955574160627954149

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Ollyws]

I'm a little confused about the expected outcome here, is the optimistically created expense NOT supposed to be translucent?

[thelullabyy]

@Ollyws I think the expected behavior:

Turn off internet, the new created invoice should display normal

is correct. Since the invoice creation was already successful, going offline afterward shouldn’t cause the invoice action to appear blurred, as that would incorrectly indicate a pending action.

[Ollyws]

Ah right sorry I wasn't reproducing it correctly.

@thelullabyy's proposal LGTM.

🎀👀🎀 C+ reviewed