Expense - Error shows up when non-admin approver submits member's report

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.91-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-122/folder/13176872/41237333/830243004?sort=%2Bidentifier
Email or phone of affected tester (no customers): joidjnsiosid2@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Create a workspace with admin, non-admin approver and member.

1. Go to staging.new.expensify.com
2. [Member} Go to workspace chat.
3. [Member] Click an empty report via + > Create report (Important).
4. [Member] On the expense preview, click Add expense > Create new expense.
5. [Member] Create an expense in the new report. Do not click Submit button.
6. [Non-admin approver] Open the workspace chat with member.
7. [Non-admin approver] Click More > Submit.

Expected Result:

Non-admin approver should be able to submit the report without issue.

Actual Result:

Non-admin approver is not able to submit the report. Error shows up.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6911425_1754657768336.bandicam_2025-08-08_20-51-26-136.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error shows up when non-admin approver submits member's report

What is the root cause of that problem?

We are enabling nonAdminApprover to submit an report is is not not allowed

What changes do you think we should make in order to solve the problem?

we should explicitly check if the current user is not admin and approver and return false for submit action so that non admin approver did not get the option to submit and expenses report of submitter

if ((submitToAccountID === report.ownerAccountID && policy?.preventSelfApproval) || (!isAdmin && isReportApprover)) {
    return false;
}

here

App/src/libs/ReportSecondaryActionUtils.ts

Lines 163 to 165 in 0754dfc

	if (submitToAccountID === report.ownerAccountID && policy?.preventSelfApproval) {
	return false;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

asking the expected results here slack

[FitseTLT]

cc @mkzie2 Isn't there another issue with the same RCA as here?

[mkzie2]

Look like it's dupe of #67181

[samranahm]

Just tested PR #68215 and can confirm that it indeed resolved this issue, we should hold this one until the linked PR is merged before closing this one.

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@strepanier03 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@strepanier03 10 days overdue. Is anyone even seeing these? Hello?

[samranahm]

PR #67942 is UP, @nlemma mind testing again so we can close this one