[Due for payment 2025-08-15] [RCA #65740] Workspace settings - Members are displayed with a fallback avatar in Add Approval Workflow

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.89-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #67178
Email or phone of affected tester (no customers): applausetester+bm688@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb, android
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Create a workspace and add members
3. Go to Workflows then click on Add approval workflows

Expected Result:

Members should be displayed with their profile avatars

Actual Result:

Members are shown with a fallback avatar

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[andriferry]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace settings - Members are displayed with a fallback avatar in Add Approval Workflow, it causing missing accountID member

What is the root cause of that problem?

accountID is existing but we are not put in the object

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsExpensesFromPage.tsx

Lines 81 to 102 in 3c1d3c5

	approvalWorkflow.members.map((member) => {
	const policyMemberEmailsToAccountIDs = getMemberAccountIDsForWorkspace(policy?.employeeList);
	const accountID = Number(policyMemberEmailsToAccountIDs[member.email] ?? '');
	const login = personalDetailLogins?.[accountID];
	return {
	text: Str.removeSMSDomain(member.displayName),
	alternateText: member.email,
	keyForList: member.email,
	isSelected: true,
	login: member.email,
	icons: [{source: member.avatar ?? FallbackAvatar, type: CONST.ICON_TYPE_AVATAR, name: Str.removeSMSDomain(member.displayName), id: accountID}],
	rightElement: (
	<MemberRightIcon
	role={policy?.employeeList?.[member.email]?.role}
	owner={policy?.owner}
	login={login}
	/>
	),
	};
	}),
	);

and also in this

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsExpensesFromPage.tsx

Lines 113 to 131 in 3c1d3c5

	const accountID = Number(policyMemberEmailsToAccountIDs[member.email] ?? '');
	const login = personalDetailLogins?.[accountID];
	return {
	text: Str.removeSMSDomain(member.displayName),
	alternateText: member.email,
	keyForList: member.email,
	isSelected: false,
	login: member.email,
	icons: [{source: member.avatar ?? FallbackAvatar, type: CONST.ICON_TYPE_AVATAR, name: Str.removeSMSDomain(member.displayName), id: accountID}],
	rightElement: (
	<MemberRightIcon
	role={policy?.employeeList?.[member.email]?.role}
	owner={policy?.owner}
	login={login}
	/>
	),
	};
	})

What changes do you think we should make in order to solve the problem?

We need to added accountID to object section , and it's gonna be

const policyMemberEmailsToAccountIDs = getMemberAccountIDsForWorkspace(policy?.employeeList);
const accountID = Number(policyMemberEmailsToAccountIDs[member.email] ?? '');
const login = personalDetailLogins?.[accountID];
return {
    text: Str.removeSMSDomain(member.displayName),
    alternateText: member.email,
    keyForList: member.email,
    isSelected: false,
    accountID,
    login: member.email,
    icons: [{source: member.avatar ?? FallbackAvatar, type: CONST.ICON_TYPE_AVATAR, name: Str.removeSMSDomain(member.displayName), id: accountID}],
    rightElement: (
        <MemberRightIcon
            role={policy?.employeeList?.[member.email]?.role}
            owner={policy?.owner}
            login={login}
        />
    ),
};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

And also after you select the member and press the continue button, You can see same issue in approval section here:

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Lines 118 to 135 in 3c1d3c5

	const accountID = Number(policyMemberEmailsToAccountIDs[email] ?? '');
	const {avatar, displayName = email, login} = personalDetails?.[accountID] ?? {};
	return {
	text: displayName,
	alternateText: email,
	keyForList: email,
	isSelected: selectedApproverEmail === email,
	login: email,
	icons: [{source: avatar ?? FallbackAvatar, type: CONST.ICON_TYPE_AVATAR, name: displayName, id: accountID}],
	rightElement: (
	<MemberRightIcon
	role={employee.role}
	owner={policy?.owner}
	login={login}
	/>
	),
	};

Solve the problem

1. Add new type called accountID: number to avoid eslint error message here:

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Lines 44 to 52 in 3c1d3c5

	type SelectionListApprover = {
	text: string;
	alternateText: string;
	keyForList: string;
	isSelected: boolean;
	login: string;
	rightElement?: React.ReactNode;
	icons: Icon[];
	};

type SelectionListApprover = {
    text: string;
    alternateText: string;
    keyForList: string;
    isSelected: boolean;
    login: string;
    rightElement?: React.ReactNode;
    icons: Icon[];
    accountID: number
};

2. Add accountID in the section

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Lines 118 to 135 in 3c1d3c5

	const accountID = Number(policyMemberEmailsToAccountIDs[email] ?? '');
	const {avatar, displayName = email, login} = personalDetails?.[accountID] ?? {};
	return {
	text: displayName,
	alternateText: email,
	keyForList: email,
	isSelected: selectedApproverEmail === email,
	login: email,
	icons: [{source: avatar ?? FallbackAvatar, type: CONST.ICON_TYPE_AVATAR, name: displayName, id: accountID}],
	rightElement: (
	<MemberRightIcon
	role={employee.role}
	owner={policy?.owner}
	login={login}
	/>
	),
	};

and it gonna be

const accountID = Number(policyMemberEmailsToAccountIDs[email] ?? '');
const {avatar, displayName = email, login} = personalDetails?.[accountID] ?? {};
return {
    text: displayName,
    alternateText: email,
    keyForList: email,
    isSelected: selectedApproverEmail === email,
    accountID,
    login: email,
    icons: [{source: avatar ?? FallbackAvatar, type: CONST.ICON_TYPE_AVATAR, name: displayName, id: accountID}],
    rightElement: (
        <MemberRightIcon
            role={employee.role}
            owner={policy?.owner}
            login={login}
        />
    ),
};

Result

Screen.Recording.2025-08-05.at.15.13.04.mov