[Due for payment 2025-08-11] [$250] Set all categories to enabled by default if unspecified in the uploaded file

[flaviadefaria]

Coming from this Slack thread

Problem:

When a user imports a spreadsheet in Categories, there’s a field called “Enabled”, that is required, however, that isn't obvious, leading the import to fail with an error message that ins't super clear to the user:

Solution:

If unspecified in the uploaded file, set all categories to enabled by default. It’s seemingly not required on OldDot; we just enable them by default in the absence of that field/column in the spreadsheet uploader, so we should remove that restriction in NewDot. It's best that we import everything as enabled since the user can manually disable what they need in the UI.

cc @rlinoz

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021949800708621982582
• Upwork Job ID: 1949800708621982582
• Last Price Increase: 2025-07-28
• Automatic offers:
• layacat | Contributor | 108221301

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @flaviadefaria

[layacat]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Set all categories to enabled by default if unspecified in the uploaded file

What is the root cause of that problem?

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Line 49 in 8039748

{text: translate('common.enabled'), value: CONST.CSV_IMPORT_COLUMNS.ENABLED, isRequired: true},

We're setting the required column here, which causes the issue.

What changes do you think we should make in order to solve the problem?

We should remove isRequired: true here

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021949800708621982582

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Importing categories and tags should not have enabled column as required, and the imported tags and categories should be enabled by default

What is the root cause of that problem?

We already have mechanism to enable the tags and categories to be imported in case enabled column is missing.

App/src/pages/workspace/tags/ImportedTagsPage.tsx

Line 102 in 4b0bfd6

enabled: tagsEnabledColumn !== -1 ? tagsEnabled?.[containsHeader ? index + 1 : index] === 'true' : true,

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Line 108 in 4b0bfd6

enabled: categoriesEnabledColumn !== -1 ? categoriesEnabled?.[containsHeader ? index + 1 : index] === 'true' : true,

so only problem right now is - the enabled column is marked as required.

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Line 49 in 4b0bfd6

{text: translate('common.enabled'), value: CONST.CSV_IMPORT_COLUMNS.ENABLED, isRequired: true},

App/src/pages/workspace/tags/ImportedTagsPage.tsx

Line 50 in 4b0bfd6

{text: translate('common.enabled'), value: CONST.CSV_IMPORT_COLUMNS.ENABLED, isRequired: true},

What changes do you think we should make in order to solve the problem?

Fix both tags and categories by simply removing isRequired: true param here.

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Line 49 in 4b0bfd6

{text: translate('common.enabled'), value: CONST.CSV_IMPORT_COLUMNS.ENABLED, isRequired: true},

App/src/pages/workspace/tags/ImportedTagsPage.tsx

Line 50 in 4b0bfd6

{text: translate('common.enabled'), value: CONST.CSV_IMPORT_COLUMNS.ENABLED, isRequired: true},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Not needed but we could still create a test by importing a few categories and tags without enabled column and test if all the imported tags and categories are enabled.

What alternative solutions did you explore? (Optional)

NA

[aadil42]

@flaviadefaria, Can you share the specific sheet you're using in the video? Thank you.

[PiyushChandra17]

🚨 Edited by proposal-police: This proposal was edited at 2025-07-28 14:11:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Set all categories to enabled by default if unspecified in the uploaded file

What is the root cause of that problem?

Currently we are adding this missingRequiredColumns check here

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Lines 67 to 69 in 2927406

	const missingRequiredColumns = requiredColumns.find((requiredColumn) => !columns.includes(requiredColumn.value));
	if (missingRequiredColumns) {
	errors.required = translate('spreadsheet.fieldNotMapped', {fieldName: missingRequiredColumns.text});

What changes do you think we should make in order to solve the problem?

Remove that check,

Update this

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Lines 67 to 69 in 2927406

	const missingRequiredColumns = requiredColumns.find((requiredColumn) => !columns.includes(requiredColumn.value));
	if (missingRequiredColumns) {
	errors.required = translate('spreadsheet.fieldNotMapped', {fieldName: missingRequiredColumns.text});

with

const validate = useCallback(() => {
        const columns = Object.values(spreadsheet?.columns ?? {});
        let errors: Errors = {};

        const duplicate = findDuplicate(columns);
        const duplicateColumn = columnRoles.find((role) => role.value === duplicate);

        const categoriesNamesColumn = columns.findIndex((column) => column === CONST.CSV_IMPORT_COLUMNS.NAME);
        const categoriesNames = categoriesNamesColumn !== -1 ? spreadsheet?.data[categoriesNamesColumn] : [];
        const containsEmptyName = categoriesNames?.some((name, index) => (!containsHeader || index > 0) && !name?.toString().trim());

        if (duplicateColumn) {
            errors.duplicates = translate('spreadsheet.singleFieldMultipleColumns', {fieldName: duplicateColumn.text});
        } else if (containsEmptyName) {
            errors.emptyNames = translate('spreadsheet.emptyMappedField', {fieldName: translate('common.name')});
        } else {
            errors = {};
        }

        return errors;
    }, [spreadsheet?.columns, spreadsheet?.data, requiredColumns, translate, columnRoles, containsHeader]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

n/A

What alternative solutions did you explore? (Optional)

We should update just enabled field isRequired: false (name does not have any side-effects)

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Line 49 in 2927406

{text: translate('common.enabled'), value: CONST.CSV_IMPORT_COLUMNS.ENABLED, isRequired: true},

roles.push(
    {text: translate('common.enabled'), value: CONST.CSV_IMPORT_COLUMNS.ENABLED, isRequired: false},
);

Result

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.