Reports - App crashes after approving expense with track expense in the same report

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.86-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #66830
Email or phone of affected tester (no customers): sdjnojosjsdosjod@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Search

Action Performed:

Precondition:

• Account has self DM and a workspace.

1. Go to staging.expensify.com
2. Go to self DM.
3. Submit a track expense in self DM.
4. Go to workspace chat.
5. Create an empty report via + > Create report.
6. On the report preview, click Add expense > Add unreported expense.
7. Select the track expense from Step 3 and click Add to report.
8. Submit another expense to the same report via + > Create expense.
9. Go to Reports > Unapproved cash.
10. Click Submit on the expense row.
11. Click Approve.

Expected Result:

App will not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

logs.txt

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[trjExpensify]

Here's the error that's appearing:

I'm actually wondering why we're showing an Approve button on this at all. This is the one cash expense on a two expense report. The other expense on the report is non-reimbursable because of that weird track to workspace flow.

[m-natarajan]

Not reproducible on Win 11/Chrome v9.1.86-0 in the adhoc build

Recording.222.mp4

[trjExpensify]

You need to take the action from within Unapproved cash in the LHN.