[Due for payment 2026-02-19] [$250] Opening an Expense in the Reports Page Also Opens the Same Expense Thread in the Inbox

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.85-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): #Migrate

Action Performed:

1. Navigate to a chat in Inbox (Concierge)
2. Go to the Reports page
3. Open an expense from a report
4. Navigate away and later go to the Inbox
5. Observe that the same expense thread is open in the Inbox thread pane

Expected Result:

Concierge still open in LHN
Activity in the Reports page should not influence or change what is shown in the Inbox
Opening an expense in one context should not affect other unrelated sections of the app

Actual Result:

The expense opened in Reports is also automatically opened in the Inbox

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1454.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021948668527477451751
• Upwork Job ID: 1948668527477451751
• Last Price Increase: 2025-07-25
• Automatic offers:
• aimane-chnaif | Contributor | 110011000

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user opens an expense report from the Reports screen, it is also automatically opened in the Inbox.

What is the root cause of that problem?

We always save the "last read" time whenever a report is opened, regardless of whether it's accessed from the Reports screen or the Search screen:

App/src/pages/home/ReportScreen.tsx

Line 504 in d4dd40a

updateLastVisitTime(reportID);

Later, when the Inbox loads, it fetches and displays the most recently accessed report based on this "last read" time:

App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx

Line 35 in d4dd40a

const initialReport = ReportUtils.findLastAccessedReport(!isBetaEnabled(CONST.BETAS.DEFAULT_ROOMS), shouldOpenOnAdminRoom());

As a result, simply previewing a report via search causes it to show up in the Inbox unintentionally.

What changes do you think we should make in order to solve the problem?

We should avoid calling the function that updates the "last read" timestamp if the report was opened from the search. This can be done by checking isInNarrowPaneModal before calling the update function:

App/src/pages/home/ReportScreen.tsx

Line 501 in d4dd40a

if (!reportID || !isFocused) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Opening an expense report from Reports page will also open it in the Inbox.

What is the root cause of that problem?

When we press Inbox, it will navigate to Home which adds a new screen to the stack.

App/src/components/Navigation/NavigationTabBar/index.tsx

Lines 113 to 120 in 76e3fe5

	const navigateToChats = useCallback(() => {
	if (selectedTab === NAVIGATION_TABS.HOME) {
	return;
	}
	hideInboxTooltip();
	Navigation.navigate(ROUTES.HOME);
	}, [hideInboxTooltip, selectedTab]);

The new report screen will show the report based on the last accessed report and the last accessed report is the expense report that we access from the Reports page.

App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx

Lines 35 to 37 in 76e3fe5

	const initialReport = ReportUtils.findLastAccessedReport(!isBetaEnabled(CONST.BETAS.DEFAULT_ROOMS), shouldOpenOnAdminRoom());
	// eslint-disable-next-line rulesdir/no-default-id-values
	return initialReport?.reportID ?? '';

What changes do you think we should make in order to solve the problem?

We can follow the same approach when pressing the search tab icon by getting the last report params.

App/src/components/Navigation/NavigationTabBar/index.tsx

Lines 122 to 150 in 76e3fe5

	const navigateToSearch = useCallback(() => {
	if (selectedTab === NAVIGATION_TABS.SEARCH) {
	return;
	}
	clearSelectedText();
	interceptAnonymousUser(() => {
	const rootState = navigationRef.getRootState() as State<RootNavigatorParamList>;
	const lastSearchNavigator = rootState.routes.findLast((route) => route.name === NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR);
	const lastSearchNavigatorState = lastSearchNavigator && lastSearchNavigator.key ? getPreservedNavigatorState(lastSearchNavigator?.key) : undefined;
	const lastSearchRoute = lastSearchNavigatorState?.routes.findLast((route) => route.name === SCREENS.SEARCH.ROOT);
	if (lastSearchRoute) {
	const {q, ...rest} = lastSearchRoute.params as SearchFullscreenNavigatorParamList[typeof SCREENS.SEARCH.ROOT];
	const queryJSON = buildSearchQueryJSON(q);
	if (queryJSON) {
	const query = buildSearchQueryString(queryJSON);
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query,
	...rest,
	}),
	);
	return;
	}
	}
	Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: buildCannedSearchQuery()}));
	});
	}, [selectedTab]);

const navigateToChats = useCallback(() => {
    if (selectedTab === NAVIGATION_TABS.HOME) {
        return;
    }

    hideInboxTooltip();
    if (shouldUseNarrowLayout) {
        Navigation.navigate(ROUTES.HOME);    
        return;
    }

    const rootState = navigationRef.getRootState() as State<RootNavigatorParamList>;
    const lastReportNavigator = rootState.routes.findLast((route) => route.name === NAVIGATORS.REPORTS_SPLIT_NAVIGATOR);
    const lastReportNavigatorState = lastReportNavigator && lastReportNavigator.key ? getPreservedNavigatorState(lastReportNavigator?.key) : undefined;
    const lastReportRoute = lastReportNavigatorState?.routes.findLast((route) => route.name === SCREENS.REPORT);

    if (lastReportRoute) {
        const {reportID} = lastReportRoute.params as ReportsSplitNavigatorParamList[typeof SCREENS.REPORT];
        Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID));
        return;
    }

    Navigation.navigate(ROUTES.HOME);    
}, [hideInboxTooltip, selectedTab]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Opening an Expense in the Reports Page Also Opens the Same Expense Thread in the Inbox

What is the root cause of that problem?

1. When clicking Inbox tab, we will be navigated to /home. And Navigation.navigate will push the new stack into rootState, causing ReportsSplitNavigator to be re-mounted:
   

   App/src/components/Navigation/NavigationTabBar/index.tsx

   Line 119 in d4dd40a

   Navigation.navigate(ROUTES.HOME);

2. When rendering, ReportsSplitNavigator only checks the reportID in the Url and the most recently opened report:
   

   App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx

   Lines 29 to 35 in d4dd40a

   	const currentURL = getCurrentUrl();
   	const reportIdFromPath = currentURL && new URL(currentURL).pathname.match(CONST.REGEX.REPORT_ID_FROM_PATH)?.at(1);
   	if (reportIdFromPath) {
   	return reportIdFromPath;
   	}
   	const initialReport = ReportUtils.findLastAccessedReport(!isBetaEnabled(CONST.BETAS.DEFAULT_ROOMS), shouldOpenOnAdminRoom());

What changes do you think we should make in order to solve the problem?

Finds and returns the reportID of the most recently opened report in the previous ReportsSplitNavigator if available:

App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx

Line 35 in d4dd40a

const initialReport = ReportUtils.findLastAccessedReport(!isBetaEnabled(CONST.BETAS.DEFAULT_ROOMS), shouldOpenOnAdminRoom());

+ const rootState = navigationRef.getRootState();
+ const preReportNavigator = rootState.routes.filter((r) => r.name === NAVIGATORS.REPORTS_SPLIT_NAVIGATOR).at(-2);
+ const preReportNavigatorState = preReportNavigator && preReportNavigator.key ? getPreservedNavigatorState(preReportNavigator?.key) : undefined;
+ const preReportRoute = preReportNavigatorState?.routes.findLast((r) => r.name === SCREENS.REPORT);
+ if (preReportRoute) {
+     const {reportID} = preReportRoute.params as ReportsSplitNavigatorParamList[typeof SCREENS.REPORT];
+     if (reportID) {
+         return reportID;
+     }
+ }
const initialReport = ReportUtils.findLastAccessedReport(!isBetaEnabled(CONST.BETAS.DEFAULT_ROOMS), shouldOpenOnAdminRoom());

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021948668527477451751