[$250] [Due for payment 2025-08-13] Remove call to `getReportNameValuePairs()` in method `canSeeDefaultRoom` from `ReportUtils.ts`

[tgolen]

This is part of #59961 and will ensure that the function is a pure function.

No proposals are necessary for this.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021956369386357944487
• Upwork Job ID: 1956369386357944487
• Last Price Increase: 2025-08-15

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[truph01]

I'm interested in working on this issue, if it's open to contributors.

[DylanDylann]

🔔 Note for Contributors: Please ensure that you are responsible in the PR phase to try to get it done soon

The function canSeeDefaultRoom() is not a pure function because it references the report's NVPs from a global variable here. This is considered an anti-pattern that we are actively working to eliminate.

✅ Your Task

1. Verify that a unit test exists for canSeeDefaultRoom() in its current form. If it doesn't, create one — and aim for high-quality, thorough coverage.

2. Refactor canSeeDefaultRoom() into a pure function, and introduce a new parameter: isReportArchived = false (It is recommended to use useReportIsArchived to get isReportArchived). And update all instances in the codebase where canSeeDefaultRoom() is called to accommodate the new isReportArchived parameter.

⚠️ Best Practices to Follow

1. Avoid adding new global references to data via Onyx.connect.
2. Avoid using isArchivedReport(nameValuePairs) unless absolutely necessary.
3. Prefer fetching data in a UI component, then pass it down via parameters.
4. Consider using the useReportIsArchived() React hook — it’s designed for this.
5. Before making changes, check if the report's NVPs are already available or if isReportArchived is already calculated or passed.

[DylanDylann]

@truph01 Please read above the guideline and let us know if you are interested in this one

[truph01]

@DylanDylann I've read the guideline