Dev - Android - App crashes when editing multiple messages and closing them

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @war-in
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Open any chat with a few messages
2. Long-press each of them and choose edit
3. Start closing them by clicking ✅
4. On the first or second tap app crashes

Expected Result:

The edit menu closes and no app crash

Actual Result:

App crashes when editing multiple messages and closing them

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.Jul.24.2025.from.Marcin.Warchol.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[war-in]

The issue looks very similar to the one @j-piasecki fixed recently: #65268
Kuba promised to take a look when he finds a moment 🙏

[clarajones-expensify]

Hi @war-in ! would you tag in the person who is going to take a look at this? Thank you!

[j-piasecki]

Hi! That would be me. I have a patch that should get rid of the crash, but I don't have the full understanding of what's happening yet so I'm not certain whether this approach is the right one.

Here's the patch so far

diff --git a/node_modules/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp b/node_modules/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp
index 0abf41a..05be813 100644
--- a/node_modules/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp
+++ b/node_modules/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp
@@ -115,6 +115,11 @@ YogaLayoutableShadowNode::YogaLayoutableShadowNode(
       if (auto layoutableChild =
               std::dynamic_pointer_cast<const YogaLayoutableShadowNode>(
                   child)) {
+
+        if (static_cast<YGDisplay>(layoutableChild->yogaNode_.style().display()) == YGDisplayContents) {
+          yogaNode_.setDirty(true);
+        }
+
         yogaLayoutableChildren_.push_back(std::move(layoutableChild));
       }
     }