Fix canBeMissing alert for for keys reportActions_undefined, reportAttributes

[iwiznia]

Keys: reportActions_undefined, reportAttributes
OG issue: https://github.com/Expensify/Expensify/issues/509711 https://github.com/Expensify/Expensify/issues/509596
Suspect introduction in #61316 or #60886 from #65032 (comment)

@bernhardoj you are the author of that PR, can you take a look at this please?

[bernhardoj]

@iwiznia do you know how we handle the case where the ID is undefined, such as reportActions_undefined?

(technically most onyx data can have missing value when the ID is undefined or invalid, report_undefined, report_-1, etc., so should we set canBeMissing to true for all dynamic onyx keys?)

[iwiznia]

In what cases do we want to subscribe to reportActions_undefined? Like we know there won't be any data there, ever.

[bernhardoj]

Yeah, but we can't conditionally use a hook. In our case, the warning shows when the report doesn't have a parentReportID, in other words, it's not a child report.

App/src/components/AvatarWithDisplayName.tsx

Line 179 in fa68395

const [parentReportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report?.parentReportID}`, {canEvict: false, canBeMissing: false});

Can we do like conditional canBeMissing?

canBeMissing: !report?.parentReportID;

[iwiznia]

Can we do like conditional canBeMissing?

I don't see why not. That sounds like the best option because we expect the data to be there when report is a child and know it won't be there when it is not

[bernhardoj]

PR is up

[melvin-bot]

This issue has not been updated in over 15 days. @iwiznia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!