[HOLD for payment 2025-08-07] [$250] Reports - Report that contains duplicate violation does not show Review button on Reports page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.83-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: 3940525 / https://docs.google.com/spreadsheets/d/1xgmP-nEeoR-F_gnhxvQucXjETKq0u7hq9oKJ5BqXMr8/edit?gid=655403539#gid=655403539&range=D13
Email or phone of affected tester (no customers): ndsoojidsjsiodj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Search

Action Performed:

1. Go to staging.expensify.com
2. Go to workspace chat.
3. Submit two expenses with the same amount, merchant and category.
   → Report preview shows Review button on the main workspace chat.
4. Go to Reports > Expenses.
5. Go to Reports > Reports.

Expected Result:

In Step 3, the report preview shows Review button on the main workspace chat because the report has a violation and requires attention. Therefore,

• in Step 4, the expense rows will show Review button.
• in Step 5, the report row will show Review button.

Actual Result:

The report preview shows Review button on the main workspace chat, but

• in Step 4, the expense rows shows View button.
• in Step 5, the report row shows Submit button.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021946237773902823154
• Upwork Job ID: 1946237773902823154
• Last Price Increase: 2025-07-18
• Automatic offers:
• FitseTLT | Contributor | 108122075

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - Report that contains duplicate violation does not show Review button on Reports page

What is the root cause of that problem?

We only consider violations here for reports

App/src/libs/SearchUIUtils.ts

Line 744 in 0717f3d

if ((isSubmitter || isApprover || isAdmin) && hasViolations(report.reportID, allViolations, undefined, allReportTransactions)) {

but duplicate violation is a warning type violation

What changes do you think we should make in order to solve the problem?

We need to consider notice type and warning type violations too just like we do for repot preview case

App/src/libs/ReportPreviewActionUtils.ts

Lines 211 to 215 in 0717f3d

	const hasAnyViolations =
	hasMissingSmartscanFields(report.reportID, transactions) ||
	hasViolations(report.reportID, violations) ||
	hasNoticeTypeViolations(report.reportID, violations, true) ||
	hasWarningTypeViolations(report.reportID, violations, true);

if (
        (isSubmitter || isApprover || isAdmin) &&
        (hasViolations(report.reportID, allViolations, undefined, allReportTransactions) ||
            hasNoticeTypeViolations(report.reportID, allViolations, true) ||
            hasWarningTypeViolations(report.reportID, allViolations, true))
    ) {

We can also consider hasMissingSmartscanFields and others to align with our ReportPreviewActionUtils logic or even use a single canReview function (or even getAction that determines the current action) accross the pages for consistency and DRY code. Because the ReportPreviewActionUtils logic has advanced a bit, as you can see

App/src/libs/ReportPreviewActionUtils.ts

Lines 220 to 227 in 0717f3d

	if (
	!hasAnyViolations ||
	isReimbursed ||
	(!(isSubmitter && isOpen && policy?.areWorkflowsEnabled) &&
	!canApprove(report, violations, policy, transactions, false) &&
	!canPay(report, violations, isReportArchived, policy, policy, false))
	) {
	return false;

we only show the review button for the user that an action is expected currently. For instance, once it is submitted we only show the review button for the approver etc.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add test for getAction to assert it returns review for warning and notice type violations

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021946237773902823154

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[rushatgabhane]

@FitseTLT's proposal sounds good to me! 🎀 👀 🎀

#66721 (comment)

[melvin-bot]

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.