[$250] Chat - Invited user's time is shown above compose box

@thesahindia

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.81-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to https://staging.new.expensify.com/home
Open self DM
Create a track expense with description
Open the expense
Tap description
Note description is shown - tap enter and bring cursor below and paste the following text
₹ uuj

7

#66

@slottwo+gdhs@gmail.com
7. Tap invite in the whisper

Expected Result:

Invited user's time must not be shown above compose box

Actual Result:

Invited user's time is shown above compose box

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

Platforms Tested:

On which of our officially supported platforms was this issue tested:

Screenshots/Videos

Add any screenshot/video evidence

Bug6890700_1752768887551.Screenrecorder-2025-07-17-21-30-37-19.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021945892449083369533
Upwork Job ID: 1945892449083369533
Last Price Increase: 2025-07-17

Issue Owner

Current Issue Owner: @thesahindia

@maddylewis

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Job added to Upwork: https://www.upwork.com/jobs/~021945892449083369533

@thesahindia

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

When we invite user to track expense thread, the invited user time is shown above composer.

What is the root cause of that problem?

We show the time based on canShowReportRecipientLocalTime. All the conditions are satisfied.

App/src/libs/ReportUtils.ts

Lines 2595 to 2609 in 5c2f566

    
           function canShowReportRecipientLocalTime(personalDetails: OnyxEntry<PersonalDetailsList>, report: OnyxEntry<Report>, accountID: number): boolean { 
        
               const reportRecipientAccountIDs = getReportRecipientAccountIDs(report, accountID); 
        
               const hasMultipleParticipants = reportRecipientAccountIDs.length > 1; 
        
               const reportRecipient = personalDetails?.[reportRecipientAccountIDs[0]]; 
        
               const reportRecipientTimezone = reportRecipient?.timezone ?? CONST.DEFAULT_TIME_ZONE; 
        
               const isReportParticipantValidated = reportRecipient?.validated ?? false; 
        
               return !!( 
        
                   !hasMultipleParticipants && 
        
                   !isChatRoom(report) && 
        
                   !isPolicyExpenseChat(getRootParentReport({report})) && 
        
                   reportRecipient && 
        
                   reportRecipientTimezone?.selected && 
        
                   isReportParticipantValidated 
        
               ); 
        
           }

What changes do you think we should make in order to solve the problem?

If we don't want to show the time in track expense thread, we can follow the existing approach as checking the root parent report and make sure it's not self DM.

!isSelfDM(getRootParentReport({report})) &&

If we want to show the time only in 1:1 chat, then we can use isOneOnOneChat instead.

return !!(
    isOneOnOneChat(report) &&
    reportRecipient &&
    reportRecipientTimezone?.selected &&
    isReportParticipantValidated
);

If we use this, the time won't show in thread anymore.

We can adjust the condition based on the requirement.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test canShowReportRecipientLocalTime and verify it returns false for self DM track expense thread.

can not reproduce it.

@maddylewis

I don't think it's a bug. @maddylewis, could you please confirm?

Issue is not reproduce.

#66648 (comment)

@maddylewis

@maddylewis it's still reproducible. You need to type a validated (existing chat) user as the mention.

@maddylewis

bump @maddylewis

@maddylewis

@maddylewis can you recheck this one please?

Navigation Menu

Repository navigation

[$250] Chat - Invited user's time is shown above compose box #66648

Action Performed:

7

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function canShowReportRecipientLocalTime(personalDetails: OnyxEntry<PersonalDetailsList>, report: OnyxEntry<Report>, accountID: number): boolean {
	const reportRecipientAccountIDs = getReportRecipientAccountIDs(report, accountID);
	const hasMultipleParticipants = reportRecipientAccountIDs.length > 1;
	const reportRecipient = personalDetails?.[reportRecipientAccountIDs[0]];
	const reportRecipientTimezone = reportRecipient?.timezone ?? CONST.DEFAULT_TIME_ZONE;
	const isReportParticipantValidated = reportRecipient?.validated ?? false;
	return !!(
	!hasMultipleParticipants &&
	!isChatRoom(report) &&
	!isPolicyExpenseChat(getRootParentReport({report})) &&
	reportRecipient &&
	reportRecipientTimezone?.selected &&
	isReportParticipantValidated
	);
	}

[$250] Chat - Invited user's time is shown above compose box #66648

Description

Action Performed:

7

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 17, 2025

melvin-bot commented on Jul 17, 2025

melvin-bot commented on Jul 17, 2025

bernhardoj commented on Jul 18, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

nabi-ebrahimi commented on Jul 18, 2025

thesahindia commented on Jul 20, 2025

kaushiktd commented on Jul 23, 2025

maddylewis commented on Jul 23, 2025

bernhardoj commented on Jul 23, 2025

bernhardoj commented on Jul 25, 2025

bernhardoj commented on Aug 4, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions