[Due for payment 2025-08-22] [HOLD for payment 2025-08-11] [$250] Expense - "Allow location" modal only appears while creating distance expense while offline.

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.82-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://docs.google.com/spreadsheets/d/1nPID07oiJkVDfW0GDmVYKrbmvse7V_3BnW-Rmyyr_Hs/edit?gid=1081597635#gid=1081597635&range=D7
Email or phone of affected tester (no customers): ibellicotest+1346@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb) - Windows 10 / Chrome
App Component: Money Requests

Action Performed:

1. Open the staging.new.expensify.com website.
2. Log in with an account where no distance expenses were created yet.
3. Open any workspace chat.
4. Create a distance expense.
5. Note that during the process, no "Allow location" modal appears.
6. Turn off internet connection.
7. Create a new distance expense.
8. Note that the "Allow Location" modal appears after tapping "Create Expense" on confirm page.

Expected Result:

"Allow Location" modal should appear when creating the first distance expense on account.

Actual Result:

"Allow Location" modal only appears when creating a distance expense while offline for the first time. Modal is not displayed when first distance expense is created while online.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021947559291283973361
• Upwork Job ID: 1947559291283973361
• Last Price Increase: 2025-07-22
• Automatic offers:
• FitseTLT | Contributor | 108172244

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - "Allow location" modal only appears while creating distance expense while offline.

What is the root cause of that problem?

When creating distance expense offline for the second time here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 184 in 48a96b0

const gpsRequired = transaction?.amount === 0 && iouType !== CONST.IOU.TYPE.SPLIT && Object.values(receiptFiles).length && !isTestTransaction;

gpsRequired will be true because the receiptFiles is {1: undefined} (we only check the length of the object.values instead of checking if there are proper receipts in the object) and transaction amount 0 .

What changes do you think we should make in order to solve the problem?

We should check that there is a non-empty value instead of only checking the length to really check that there is a proper receipt

    const gpsRequired = transaction?.amount === 0 && iouType !== CONST.IOU.TYPE.SPLIT && Object.values(receiptFiles).find(Boolean) && !isTestTransaction;

We can alternatively avoid setting an undefined on the receipt object here

We can apply similar fixes in other pages on the logic of gpsRequired if needed

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Line 592 in 48a96b0

const gpsRequired = initialTransaction?.amount === 0 && iouType !== CONST.IOU.TYPE.SPLIT;

We could also check if this is a receipt request (requestType) or not a distance request but checking the receipt file properly already works perfect because we also check the amount to be 0.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021947559291283973361

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@FitseTLT Thanks for the proposal.

gpsRequired will be true because the receiptFiles is {1: undefined}

Do you know why is the receipt undefined? Does this happen only when offline?

[FitseTLT]

@FitseTLT Thanks for the proposal.

gpsRequired will be true because the receiptFiles is {1: undefined}

Do you know why is the receipt undefined? Does this happen only when offline?

It happens in any mode whenever the transaction has no receipt because we don't check if the receipt exists when we set it here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 390 in 55c73af

newReceiptFiles = {...newReceiptFiles, [item.transactionID]: item.receipt};

the reason it only happens for distance in offline mode is because amount is zero here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 184 in 48a96b0

const gpsRequired = transaction?.amount === 0 && iouType !== CONST.IOU.TYPE.SPLIT && Object.values(receiptFiles).length && !isTestTransaction;