[Due for payment 2025-08-11] [$250] Expense - "Edit Expense" is shown on context menu on Self DM but not on WS or 1:1 chats

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.81-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+1322@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Prerequisite: Account has at least one workspace
Prerequisite 2: Account has a Self DM

1. Open the Expensify app
2. Open Self DM
3. Create a track expense
4. Long tap on the just created expense
5. Note that "Edit Expense" option is available on context menu
6. Navigate to any workspace chat
7. Submit an expense
8. Long tap on the just created expense
9. Note that "Edit Expense" option is not available on context menu
10. Navigate to an individual chat
11. Submit an expense
12. Long tap on the just created expense
13. Note that "Edit Expense" is not available on context menu

Expected Result:

"Edit Expense" option should be available on context menu for expenses created on Self DM and also for expenses created on workspaces or individual chats

Actual Result:

"Edit Expense" option is shown in context menu only for track expenses on Self DM. Expenses on workspaces chats and individual chats, doesn´t display this option on context menu

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6888735_1752600461447.Edit.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021947451551735337970
• Upwork Job ID: 1947451551735337970
• Last Price Increase: 2025-07-22
• Automatic offers:
• mkzie2 | Contributor | 108151592

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Edit Expense" is shown on context menu on Self DM but not on WS or 1:1 chats

What is the root cause of that problem?

We are only checking for selfDM here

App/src/libs/ReportUtils.ts

Lines 4254 to 4268 in 1d14859

	function canEditReportAction(reportAction: OnyxInputOrEntry<ReportAction>): boolean {
	const isCommentOrIOU = reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT || reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU;
	const message = reportAction ? getReportActionMessageReportUtils(reportAction) : undefined;
	return !!(
	reportAction?.actorAccountID === currentUserAccountID &&
	isCommentOrIOU &&
	(!isMoneyRequestAction(reportAction) || canEditMoneyRequest(reportAction)) && // Returns true for non-IOU actions
	!isReportMessageAttachment(message) &&
	((!reportAction.isAttachmentWithText && !reportAction.isAttachmentOnly) || !reportAction.isOptimisticAction) &&
	!isDeletedAction(reportAction) &&
	!isCreatedTaskReportAction(reportAction) &&
	reportAction?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE
	);
	}

What changes do you think we should make in order to solve the problem?

we should also include a chekc for IOU and expense chat

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Edit Expense" option is shown in context menu only for track expenses on Self DM. Expenses on workspaces chats and individual chats, doesn´t display this option on context menu

What is the root cause of that problem?

The preview in the selfDM is an IOU action, then canEditReportAction returns true if the user can edit this action.

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 337 in c15b065

type === CONST.CONTEXT_MENU_TYPES.REPORT_ACTION && canEditReportAction(reportAction) && !isArchivedRoom && !isChronosReport,

For the DM or workspace chat, the preview is an REPORTPREVIEW action then this function return false because the action is not add comment or IOU action.

App/src/libs/ReportUtils.ts

Lines 4260 to 4280 in c15b065

	function canEditReportAction(reportAction: OnyxInputOrEntry<ReportAction>): boolean {
	const isCommentOrIOU = reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT || reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU;
	const message = reportAction ? getReportActionMessageReportUtils(reportAction) : undefined;
	return !!(
	reportAction?.actorAccountID === currentUserAccountID &&
	isCommentOrIOU &&
	(!isMoneyRequestAction(reportAction) || canEditMoneyRequest(reportAction)) && // Returns true for non-IOU actions
	!isReportMessageAttachment(message) &&
	((!reportAction.isAttachmentWithText && !reportAction.isAttachmentOnly) || !reportAction.isOptimisticAction) &&
	!isDeletedAction(reportAction) &&
	!isCreatedTaskReportAction(reportAction) &&
	reportAction?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE
	);
	}
	/**
	* This function is needed due to the fact that when we first create an empty report, its preview action has an actorAccountID of '0'.
	* This is not the case when the report is automatically created by adding expenses to the chat where no open report is available.
	* Can be simplified by comparing actorAccountID to accountID when mentioned issue is no longer a thing on a BE side.
	*/

What changes do you think we should make in order to solve the problem?

For the report preview action, we can check canEditReportAction of moneyRequestAction. The moneyRequestAction only exists if the expense/iou report is a one-expense report, so it's safe to check canEditReportAction(moneyRequestAction) without checking reportAction is report preview or not.

shouldShow: ({type, reportAction, isArchivedRoom, isChronosReport, moneyRequestAction}) =>
            type === CONST.CONTEXT_MENU_TYPES.REPORT_ACTION && (canEditReportAction(reportAction) || canEditReportAction(moneyRequestAction)) && !isArchivedRoom && !isChronosReport,
        onPress: (closePopover, {reportID, reportAction, draftMessage, moneyRequestAction}) => {
            if (isMoneyRequestAction(reportAction) || isMoneyRequestAction(moneyRequestAction)) {
                hideContextMenu(false);
                const childReportID = reportAction?.childReportID;
                openReport(childReportID);
                Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(childReportID));
                return;
            }

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 337 in c15b065

type === CONST.CONTEXT_MENU_TYPES.REPORT_ACTION && canEditReportAction(reportAction) && !isArchivedRoom && !isChronosReport,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021947451551735337970

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)