[Due for payment 2025-08-26] [$250] Report - Empty report is displayed after splitting track expense and deleting the report.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.81-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6497312&group_by=cases:section_id&group_order=asc&group_id=377520
Email or phone of affected tester (no customers): ibellicotest+1316@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace.
Prerequisite 2: Account has a Self DM.

1. Open the Expensify app.
2. Open any workspace chat.
3. Submit a manual expense.
4. Navigate to Self DM.
5. Create a manual track expense.
6. Open the just created track expense.
7. Tap on the report field and select the workspace where the first expense was created.
8. Open the just moved expense.
9. Tap on "More" and select "Split"
10. Save the splits amount.
11. Once redirected to report, tap on "More"
12. Delete the report.
13. Note that you land on a report without any information after this last action.

Expected Result:

After moving a track expense to a report on a workspace, splitting it and deleting the report, user should land on Self DM again, where the deleted expense should be moved after deleted.

Actual Result:

On Android app after moving a track expense to a report on a worksapce, splitting it and deleting the report, user lands on a report without amount or any information in it . Llong loading on Web and mWeb.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021946208385203224306
• Upwork Job ID: 1946208385203224306
• Last Price Increase: 2025-07-25
• Automatic offers:
• huult | Contributor | 108234408

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nabi-ebrahimi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report - Empty report is displayed after splitting track expense and deleting the report.

What is the root cause of that problem?

When we open the expense thread report and move the expense to the workspace, the report page remains in the browser history. After that, if we split the moved expense — which deletes the transaction thread report — the browser history still points to the now-deleted report.

And in onConfirm delete, we call Navigation.goBack();

App/src/components/MoneyReportHeader.tsx

Lines 1124 to 1131 in d212634

	onConfirm={() => {
	setIsDeleteReportModalVisible(false);
	Navigation.goBack();
	InteractionManager.runAfterInteractions(() => {
	deleteAppReport(moneyRequestReport?.reportID);
	});
	}}

Which comes to this page. That transaction thread report no longer exists.

Then, after the deleteAppReport function moves all expenses and removes the current report, it redirects back to the expense report page.

The Navigation.goBack(); call before deleteAppReport(moneyRequestReport?.reportID); doesn't do what it should do.

What changes do you think we should make in order to solve the problem?

We can store the report ID in a ref and check if the transaction thread report still exists. If it no longer exists, we should call goBack.

Add the following snippet here

App/src/pages/home/ReportScreen.tsx

Lines 135 to 169 in 2583d8a

	function ReportScreen({route, navigation}: ReportScreenProps) {
	const styles = useThemeStyles();
	const {translate} = useLocalize();
	const reportIDFromRoute = getNonEmptyStringOnyxID(route.params?.reportID);
	const reportActionIDFromRoute = route?.params?.reportActionID;
	const isFocused = useIsFocused();
	const prevIsFocused = usePrevious(isFocused);
	const firstRenderRef = useRef(true);
	const [firstRender, setFirstRender] = useState(true);
	const isSkippingOpenReport = useRef(false);
	const flatListRef = useRef<FlatList>(null);
	const {isBetaEnabled} = usePermissions();
	const {isOffline} = useNetwork();
	const {shouldUseNarrowLayout, isInNarrowPaneModal} = useResponsiveLayout();
	const currentReportIDValue = useCurrentReportID();
	const [modal] = useOnyx(ONYXKEYS.MODAL, {canBeMissing: false});
	const [isComposerFullSize = false] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_IS_COMPOSER_FULL_SIZE}${reportIDFromRoute}`, {canBeMissing: true});
	const [accountManagerReportID] = useOnyx(ONYXKEYS.ACCOUNT_MANAGER_REPORT_ID, {canBeMissing: true});
	const [accountManagerReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${getNonEmptyStringOnyxID(accountManagerReportID)}`, {canBeMissing: true});
	const [userLeavingStatus = false] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}${reportIDFromRoute}`, {canBeMissing: true});
	const [reportOnyx] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportIDFromRoute}`, {allowStaleData: true, canBeMissing: true});
	const [reportNameValuePairsOnyx] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${reportIDFromRoute}`, {allowStaleData: true, canBeMissing: true});
	const [reportMetadata = defaultReportMetadata] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportIDFromRoute}`, {canBeMissing: true, allowStaleData: true});
	const [policies = getEmptyObject<NonNullable<OnyxCollection<OnyxTypes.Policy>>>()] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {allowStaleData: true, canBeMissing: false});
	const [parentReportAction] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${getNonEmptyStringOnyxID(reportOnyx?.parentReportID)}`, {
	canEvict: false,
	selector: (parentReportActions) => getParentReportAction(parentReportActions, reportOnyx?.parentReportActionID),
	canBeMissing: true,
	});
	const deletedParentAction = isDeletedParentAction(parentReportAction);
	const prevDeletedParentAction = usePrevious(deletedParentAction);
	const permissions = useDeepCompareRef(reportOnyx?.permissions);

    const reportIdRef = useRef<string | undefined>(null);

    useFocusEffect(() => {
        if (!reportIdRef.current && reportOnyx?.reportID) {
            reportIdRef.current = reportOnyx?.reportID;
        } else {
            if (reportOnyx?.reportID) {
                return;
            }

            Navigation.goBack(route.params.backTo ?? undefined);
        }
    });

Demo

Screen.Recording.1404-04-24.at.5.04.17.PM.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021946208385203224306

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)