[Follow up] Split Even, Split by %, Split by days

[garrettmknight]

[DESIGN DOC]
FIGMA

As a follow up to Split expenses in NewDot, we want to add a few functions we support in Classic to make common split cases easier.

Split Even:

1. Submitter creates an expense for $200.
2. Submitter taps 'Split' from the 'More' menu. Two even splits are created in the Split table, each for $100.
3. Submitter taps 'Add Split'. The new split is set to $0.
4. Submitter taps 'More'
5. Submitter taps 'Split all evenly'
6. The two splits are all updated in the table to be $66.66.
7. The final split is updated in the table for be $66.67.

Split by %:

1. Submitter creates an expense for $200.
2. Submitter taps 'Split' from the 'More' menu. Two even splits are created in the Split table, each for $100.
3. Submitter taps 'Add Split'. The new split is set to $0.
4. Submitter taps 'More'
5. Submitter taps 'Split by percentage'
6. The Split by percentage page shows, with existing amounts and resulting percentages:

• Split 1: $100 / 50%
• Split 2: $100 / 50%
• Split 3: $0 / 0%

7. Submitter changes Split 3's percentage to 50% > error shows reading "Total percentage is greater than 100%"
8. Submitter changes Split 2's percentage to 25% > greater than error remains
9. Submitter changes Split 1's percentage to 0% > error shows reading "Total percentage is less than 100%"
10. Submitter changes Split 1's percentage to 25% > error is removed
11. Submitter taps 'Continue' and is returned to the split table with the updated amounts

Split by Days:

1. Submitter creates an expense for $200.
2. Submitter taps 'Split' from the 'More' menu. Two even splits are created in the Split table, each for $100.
3. Submitter taps 'More'
4. Submitter taps 'Split by days'
5. Submitter taps 'Start' date picker, selects January 16th
6. Submitter taps 'End' date picker, selects January 18th
7. Submitter taps 'Continue'
8. 3 even expenses are added to the split table. One for the 16th ($66.66), one for the 17th ($66.66), and one for the 18th ($66.67).

[melvin-bot]

Current assignee @garrettmknight is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[garrettmknight]

@dubielzyk-expensify took a spin through what I think these follow up split features might look like. Mind reviewing and letting me know your thoughts?

[dubielzyk-expensify]

• Changed old inputs to new inputs
• Fixed error messages
• Added some comments on variations for @Expensify/design team as the percentage one gives us some interesting things to work around
• You have Split by and Split amounts interchanged in a few of these. Would be good to settle on one. I think Split amounts might make more sense cause you're not re-splitting it, but rather moving the amounts around (except for date, but whatever 😅)

[JmillsExpensify]

Super small feedback, though I don't love all the repetition of Split. Can we remove Split and focus on the types? I think the context is already very clear.

So then the choices are:

• Days
• Evenly
• Percentage

[garrettmknight]

You have Split by and Split amounts interchanged in a few of these. Would be good to settle on one. I think Split amounts might make more sense cause you're not re-splitting it, but rather moving the amounts around (except for date, but whatever 😅)

I'd been toying around with a few different copy changes and didn't consolidate. The menu of options is a bit inconsistent with % potentially updating the UI and others just updating the amount/splits. If that's an inconsistency we can live with, I kinda like these as a visual indicator of which split mode you're in:
Split mode:

• By amount
• Evenly
• By percentage
• By day

[shawnborton]

I think that makes sense Jason, I agree with your feedback. Will leave comments in the Figma too.

[danielrvidal]

Not sure if we need to yea, but do we think the split by line item function (hotels) would be in this section too? We probably don't need to account for it yet but I was thinking if we're going to future proof, we might want to think about it.