Repository navigation
Remove remaining withOnyx HOCs from the project | Cleanup #65971
Description
Activity
This issue is on HOLD until all the other refactors of the parent issue are done.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove remaining withOnyx HOCs from the project | Cleanup
What is the root cause of that problem?
- Refactor/Cleanup
What changes do you think we should make in order to solve the problem?
- We should update/remove all the references to withOnyx, comment:
- There are 7 references/comment to
withOnyxin README.md. - Remove
withOnyx, useOnyxfrom here and exportuseOnyxhook if needed (run lint after removing this). - There are 3 references/comment to `withOnyx`` in contributingGuides/STYLE.md
- Update the comment here.
- Update
withOnyxfrom the comment here. - Update the comments here, here, here and here.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Result
@fabioh8010 I would like to work on this once we remove the hold.
Whoops! This issue is 2 days overdue. Let's get this updated quick!
6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
12 days overdue. Walking. Toward. The. Light...
This issue has not been updated in over 14 days. eroding to Weekly issue.
12 remaining items
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.19-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-10-06. 🎊
For reference, here are some details about the assignees on this issue:
- @fabioh8010 does not require payment (Contractor)
We are done here
I'm owed a payment for this for the review of #69707
Parent issue: #64225
Let's refactor the following files to use
useOnyxinstead ofwithOnyx. All the work must be done in one PR.After refactor please test them extensively and provide test steps in your PR. In case of questions please ask in
#expensify-open-sourcechannel.This issue is just cleanup, remove written references to withOnyx, comments, etc. It MUST be the last issue to be worked on!