Skip to content

Remove remaining withOnyx HOCs from the project | Cleanup #65971

Description

@fabioh8010

Parent issue: #64225

Let's refactor the following files to use useOnyx instead of withOnyx. All the work must be done in one PR.

After refactor please test them extensively and provide test steps in your PR. In case of questions please ask in #expensify-open-source channel.

This issue is just cleanup, remove written references to withOnyx, comments, etc. It MUST be the last issue to be worked on!

Activity

fabioh8010 commented on Jul 11, 2025

@fabioh8010
ContributorAuthor

This issue is on HOLD until all the other refactors of the parent issue are done.

Krishna2323 commented on Jul 15, 2025

@Krishna2323
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove remaining withOnyx HOCs from the project | Cleanup

What is the root cause of that problem?

  • Refactor/Cleanup

What changes do you think we should make in order to solve the problem?

  • We should update/remove all the references to withOnyx, comment:
  • There are 7 references/comment to withOnyx in README.md.
  • Remove withOnyx, useOnyx from here and export useOnyx hook if needed (run lint after removing this).
  • There are 3 references/comment to `withOnyx`` in contributingGuides/STYLE.md
  • Update the comment here.
  • Update withOnyx from the comment here.
  • Update the comments here, here, here and here.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Result

Krishna2323 commented on Jul 15, 2025

@Krishna2323
Contributor

@fabioh8010 I would like to work on this once we remove the hold.

melvin-bot commented on Jul 18, 2025

@melvin-bot

Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot commented on Jul 22, 2025

@melvin-bot

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot commented on Jul 24, 2025

@melvin-bot

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

melvin-bot commented on Jul 28, 2025

@melvin-bot

12 days overdue. Walking. Toward. The. Light...

melvin-bot commented on Jul 31, 2025

@melvin-bot

This issue has not been updated in over 14 days. eroding to Weekly issue.

12 remaining items

added
Awaiting PaymentAuto-added when associated PR is deployed to production
and removed on Sep 29, 2025
changed the title [-]Remove remaining withOnyx HOCs from the project | Cleanup[/-] [+][Due for payment 2025-10-06] Remove remaining withOnyx HOCs from the project | Cleanup[/+] on Sep 29, 2025

melvin-bot commented on Sep 29, 2025

@melvin-bot

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot commented on Sep 29, 2025

@melvin-bot

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.19-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-10-06. 🎊

For reference, here are some details about the assignees on this issue:

roryabraham commented on Oct 14, 2025

@roryabraham
Contributor

We are done here

changed the title [-][Due for payment 2025-10-06] Remove remaining withOnyx HOCs from the project | Cleanup[/-] [+]Remove remaining withOnyx HOCs from the project | Cleanup[/+] on Oct 14, 2025

eVoloshchak commented on Jan 8, 2026

@eVoloshchak
Contributor

I'm owed a payment for this for the review of #69707

mallenexpensify commented on Jan 31, 2026

@mallenexpensify
Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions