Repository navigation
[Due for payment 2025-08-15] [Due for payment 2025-07-28] [$250] Remove remaining withOnyx HOCs from the project | Batch 6 #65967
Description
Activity
Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove remaining withOnyx HOCs
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
Update these places to use the
useOnyxhook and removewithOnyxHOCsconst [credentials] = useOnyx(ONYXKEYS.CREDENTIALS, {canBeMissing: true});App/src/pages/signin/ChangeExpensifyLoginLink.tsx
Lines 43 to 45 in 0523929
const [credentials] = useOnyx(ONYXKEYS.CREDENTIALS, {canBeMissing: true}); const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});App/src/pages/signin/ChooseSSOOrMagicCode.tsx
Lines 97 to 100 in 0523929
const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});App/src/pages/signin/ThirdPartySignInPage.tsx
Lines 86 to 89 in 0523929
const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});App/src/pages/UnlinkLoginPage.tsx
Lines 46 to 48 in 0523929
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
- changed the title
[-]Remove remaining withOnyx HOCs from the project | Batch 6[/-][+][$250] Remove remaining withOnyx HOCs from the project | Batch 6[/+]on Jul 14, 2025 Job added to Upwork: https://www.upwork.com/jobs/~021944840343036134470
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (
External)📣 @thelullabyy 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖16 remaining items
Issue is ready for payment but no BZ is assigned. @NicMendonca you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Reacted by Nicole MendoncaPayment summary
Contributor+: @@ishpaul777 - Paid $250 via NewDot
Contributor: @thelullabyy - Paid $250 via Upwork (done ✅ )@ishpaul777 Follow up PR is up. Please help check, thanks
- changed the title
[-][Due for payment 2025-07-28] [$250] Remove remaining withOnyx HOCs from the project | Batch 6[/-][+][Due for payment 2025-08-15] [Due for payment 2025-07-28] [$250] Remove remaining withOnyx HOCs from the project | Batch 6[/+]on Aug 8, 2025 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.90-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-15. 🎊
For reference, here are some details about the assignees on this issue:
- @ishpaul777 requires payment through NewDot Manual Requests
- @thelullabyy requires payment automatic offer (Contributor)
@ishpaul777 has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
- Vendor found in VML: True. Status: Active
- Amount requested: $250.00 (Matches the payment summary here: [Due for payment 2025-08-15] [Due for payment 2025-07-28] [$250] Remove remaining withOnyx HOCs from the project | Batch 6 #65967 (comment).)
- I, @twisterdotcom am not already the BZ assignee. I have approved this payment.
Zapier Logs
Run ID: 00040eee-7fab-a6a6-a261-662d8ccb8321
Parent issue: #64225
Let's refactor the following files to use
useOnyxinstead ofwithOnyx. All the work must be done in one PR.After refactor please test them extensively and provide test steps in your PR. In case of questions please ask in
#expensify-open-sourcechannel.Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @NicMendonca