[Due for payment 2025-08-11] [$250] Expense - "x per person" is shown on confirm page but missing in transaction thread

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.79-11
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/cases/view/4336068
Email or phone of affected tester (no customers): dsosdpskomsdks@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• "Attendee tracking" is enabled in Rules.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Create expense > Manual.
4. Enter amount > Next.
5. On confirmation page, click Attendees.
6. Select one more attendee.
7. Click Save.
   → Attendees field has "x per person" on the confirmation page.
8. Click Create expense.
9. Go to transaction thread.

Expected Result:

In transaction thread, Attendees field will also show "x per person".

Actual Result:

In transaction thread, Attendees field is missing "x per person".

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021944719861039808242
• Upwork Job ID: 1944719861039808242
• Last Price Increase: 2025-07-14
• Automatic offers:
• FitseTLT | Contributor | 108162409

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - "x per person" is shown on confirm page but missing in transaction thread

What is the root cause of that problem?

We are only displaying per person when the request is per-diem or a reciept request

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 175 in e766c7f

shouldDisplayTransactionAmount && ((hasReceipt && !isTransactionScanning && didReceiptScanSucceed) || isPerDiemRequest)

What changes do you think we should make in order to solve the problem?

All we want to check is that the request is not pending receipt scanning request and distance request like the confirmation page

App/src/components/MoneyRequestConfirmationList.tsx

Lines 358 to 361 in 509bd7b

	const formattedAmountPerAttendee =
	isDistanceRequestWithPendingRoute || isScanRequest
	? ''
	: convertToDisplayString(amountToBeUsed / (iouAttendees?.length && iouAttendees.length > 0 ? iouAttendees.length : 1), isDistanceRequest ? currency : iouCurrencyCode);

so the condition shouldDisplayTransactionAmount ensures amount is available and route exists for distance request so we should only confirm that the receipt scanning has succeeded if there is a receipt.

const formattedPerAttendeeAmount =
        shouldDisplayTransactionAmount && (!hasReceipt || (!isTransactionScanning && didReceiptScanSucceed))
            ? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency)
            : '';

Alternatively we can replace hasReceipt with isScanRequest on the transaction to show the per-person in case of a manual request with receipt because we already have the amount set manually and we shouldn't wait for the receipt scanning to be complete.
or we can use only shouldDisplayTransactionAmount which will ensure that there is an amount set on the transaction because amount will be availabe when scanning is complete for receipt request or when a distance request is resolved.

const formattedPerAttendeeAmount =
        shouldDisplayTransactionAmount 
            ? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency)
            : '';

If we want to be extra careful we can assert that a distance request hasRoute because now in determining shouldDisplayTransactionAmount we are allowing if the transaction has amount (which basically is enough because distance request with amount means it has the route determined already)

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 172 in 509bd7b

const shouldDisplayTransactionAmount = ((isDistanceRequest && hasRoute) || !!transactionAmount) && transactionAmount !== undefined;

So with all the suggestion and extra care the condition would look like

const formattedPerAttendeeAmount =
        shouldDisplayTransactionAmount && (!isScanRequest(updatedTransaction ?? transaction) || (!isTransactionScanning && didReceiptScanSucceed)) && (!isDistanceRequest || hasRoute)
            ? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency)
            : '';

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In transaction thread, Attendees field is missing "x per person".

What is the root cause of that problem?

Here is the place to show "x per person"

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 796 in c9b2df7

? `${CONST.DOT_SEPARATOR} ${formattedPerAttendeeAmount} ${translate('common.perPerson')}`

However the formattedPerAttendeeAmount is empty due to the fact that we don't handle the case for manual and distance

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 173 to 176 in c9b2df7

	const formattedPerAttendeeAmount =
	shouldDisplayTransactionAmount && ((hasReceipt && !isTransactionScanning && didReceiptScanSucceed) || isPerDiemRequest)
	? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency)
	: '';

What changes do you think we should make in order to solve the problem?

We should allow to show split bill info for other cases such as manual input & distance as well

• Check if it is manual report (Since it always valid so isManualRequest is enough)
• Check if it distance report that has routes

    const formattedPerAttendeeAmount =
        shouldDisplayTransactionAmount && ((hasReceipt && !isTransactionScanning && didReceiptScanSucceed) || isPerDiemRequest || (isDistanceRequest && hasRoute) || isManualRequest(transaction))
            ? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency)
            : '';

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 173 to 176 in c9b2df7

	const formattedPerAttendeeAmount =
	shouldDisplayTransactionAmount && ((hasReceipt && !isTransactionScanning && didReceiptScanSucceed) || isPerDiemRequest)
	? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency)
	: '';

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[VictoriaExpensify]

Yeah we should definitely fix this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021944719861039808242