Some filter show circles and others show squares

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.76-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #65235
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: Chat Report View

Action Performed:

1. Open the ND app
2. Sign into a valid account
3. Go to report > access drop downs > observe the geometric shapes

Expected Result:

All of them should be circles, or all squares

Actual Result:

Some are circles and others squares

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6877487_1751578920892.Some_show_circles_and_others_squares.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[linhvovan29546]

I think that is expected based on the #64021 (comment)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Some filter show circles and others show squares

What is the root cause of that problem?

• The reported bug is expected behaviour but the start group chat page does not match with the new UI design patterns which uses a checkbox for multi-select lists:

What changes do you think we should make in order to solve the problem?

• We need to update the itemRightSideComponent to use Checkbox like in other multi select lists:

// Pseudocode
<Checkbox
    shouldSelectOnPressEnter
    isChecked={!!item.isSelected}
    accessibilityLabel={item.text ?? ''}
    onPress={() => toggleOption(item)}
/>

• We should also check other props which are implemented in itemRightSideComponent.
• A few other components use SelectCircle, so we should check whether they render it for multi-select lists and, if so, update them to use Checkbox. One of them is SelectableListItem.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Result

[Krishna2323]

@Expensify/design, I believe that the start chat page does not follow the new UI design patterns, could you please check that? Thanks!

[RachCHopkins]

Some filter show circles and others show squares

This statement is misguided. A "circle" is a radio button - You can choose one. A "square" is a check box - You can choose more than one.

observe the geometric shapes

These are not "geometric shapes" they are web input elements.

Radio buttons and check boxes are things with specific functions. This is not a bug.

Or, as Google's AI summarises it:

Radio buttons and checkboxes are both input elements used for user selection, but they serve different purposes. Radio buttons are used for mutually exclusive selections, where only one option can be chosen from a group. Checkboxes, on the other hand, allow users to select one or more options from a group.

[RachCHopkins]

@Krishna2323 the screenshot you have used is not related to a report filter. The OP refers to this one:

[Krishna2323]

the screenshot you have used is not related to a report filter. The OP refers to this one:

@RachCHopkins, I agree but just wanted report that the start chat page (which uses a multi-select list) is currently using radio buttons, which is incorrect and does not align with the new UI patterns. I believe that should be fixed for consistency.

[RachCHopkins]

Ok, that's not really a discussion for this issue.